Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reftests take screenshot too early in Chrome #5412

Closed
gsnedders opened this issue Apr 6, 2017 · 4 comments
Closed

Reftests take screenshot too early in Chrome #5412

gsnedders opened this issue Apr 6, 2017 · 4 comments

Comments

@gsnedders
Copy link
Member

gsnedders commented Apr 6, 2017

Probably w3c/wptrunner#241

Almost identical to to #6328.

w3c/csswg-drafts#1088 is the issue that causes the issue here. Notably, wptrunner needs to block screenshots on fonts loading.

cc/ @jgraham @jugglinmike @bobholt

@gsnedders
Copy link
Member Author

Actually, it's worse than that, as discussed in the email thread:

We need to take a screenshot after:

  • after the document's load event has been fired
  • the document.fonts.ready promise being fulfilled
  • all @imports from stylesheets have been loaded
  • after all subresources in all stylesheets have been loaded (so background-image, content, etc.)

And the last two of those can't be detected through JS. :\

@gsnedders
Copy link
Member Author

OK, maybe the last two block the load event in Chrome per #5525 so maybe we're okay.

@gsnedders gsnedders changed the title Flaky reftests in Chrome on stability checker Reftests take screenshot too early in Chrome Jul 1, 2017
@foolip
Copy link
Member

foolip commented Jul 6, 2017

https://bugs.chromium.org/p/chromium/issues/detail?id=507054 is the Chromium bug tracking document.fonts.ready being fulfilled. That may not be the only required fix, but I think we should treat this as blocked on that.

@gsnedders
Copy link
Member Author

@foolip that bug is only really about the Blink test runner, is it not? whereas, I believe, this is about wptrunner.

gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Jul 14, 2017
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Jul 14, 2017
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Jul 14, 2017
jgraham pushed a commit that referenced this issue Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants