-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reftests take screenshot too early in Chrome #5412
Comments
Actually, it's worse than that, as discussed in the email thread: We need to take a screenshot after:
And the last two of those can't be detected through JS. :\ |
OK, maybe the last two block the load event in Chrome per #5525 so maybe we're okay. |
https://bugs.chromium.org/p/chromium/issues/detail?id=507054 is the Chromium bug tracking document.fonts.ready being fulfilled. That may not be the only required fix, but I think we should treat this as blocked on that. |
@foolip that bug is only really about the Blink test runner, is it not? whereas, I believe, this is about wptrunner. |
Fixes web-platform-tests#6328. Fixes web-platform-tests#5412. Partially fixes web-platform-tests#6327.
Fixes web-platform-tests#6328. Fixes web-platform-tests#5412. Fixes, partially, web-platform-tests#6327.
Fixes web-platform-tests#6328. Fixes web-platform-tests#5412. Fixes, partially, web-platform-tests#6327.
Probably w3c/wptrunner#241Almost identical to to #6328.
w3c/csswg-drafts#1088 is the issue that causes the issue here. Notably, wptrunner needs to block screenshots on fonts loading.
cc/ @jgraham @jugglinmike @bobholt
The text was updated successfully, but these errors were encountered: