-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a few tests for whether CSS subresources are critical #5525
base: master
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
2c1e04c
to
93a6ffa
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
9e253eb
to
7db2338
Compare
b6b3856
to
79ba9af
Compare
While the CSS WG has still not resolved the above issue, these tests do at this point show identical behaviour across all three major browser engines, hence on the whole I'd be in favour of landing these as tentative tests if someone wants to review them. |
For some reason this thread was buried in my inbox and it doesn't look there's been much activity in a while. Are you still seeking review @gsnedders? Has there been any more consensus or spec updates here? |
Not that I'm aware of; that said, I'm still in favour of review (and landing) the tests which pass in all three major browser engines, as we may as well have tentative tests that assert the current intersection behaviour (and ensure we don't move away from interoperability there). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM % a couple of comments. Also, maybe we can change instances of var
to let
or const
appropriately?
<script src="/resources/testharness.js"></script> | ||
<script src="/resources/testharnessreport.js"></script> | ||
<script> | ||
</script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this <script></script>
needed?
font: 25px/1 Revalia; | ||
} | ||
</style> | ||
<div id=foo>XXX</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In 2/4 font-using tests in this PR, the id=foo
element comes before the <style>
that includes the font, and in the other 2/4 it is the opposite. Can we make this consistent? (Not that it really matters much...)
Another variation for these tests that could be useful to include in this PR is: moving all of the In w3c/csswg-drafts#1088 (comment), Hiroshige points out that apparently Chrome blocks the Document's load event in some cases where the |
I'll fix the nits you mentioned above, but I probably won't expand the coverage of this (I don't really immediately have the time to actually work on this right now). |
Let me know whenever you do and I'm happy to re-review |
tests for w3c/csswg-drafts#1088
these should be moved somewhere better once we know what directory to put them in