Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image shape margin tests #5278

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Image shape margin tests #5278

wants to merge 2 commits into from

Conversation

gsnedders
Copy link
Member

@gsnedders gsnedders commented Mar 31, 2017 •
edited by wpt-pr-bot
Loading

Originally posted as w3c/csswg-test#567 by @rhauck on 26 Jul 2014, 00:06 UTC:

@wpt-pr-bot
Copy link
Collaborator

Notifying @astearns, @atanassov, @bemjb, @kojiishi, @plinss, and @zhorvath. (Learn how reviewing works.)

@wpt-issue-mover wpt-issue-mover changed the title Csswg test pr 567 Image shape margin tests Mar 31, 2017
@wpt-issue-mover
Copy link

Originally posted as w3c/csswg-test#567 (comment) by @bemjb on 31 Jul 2014, 21:48 UTC:

Most of them look good to me.

The image in shape-image-margin-001.html spills into the right margin, so it would have the same result with or without the shape-margin. It should be reworked so that the shape-margin is what affects the wrapping of the text.

@wpt-issue-mover
Copy link

Originally posted as w3c/csswg-test#567 (comment) by @bemjb on 01 Aug 2014, 17:41 UTC:

Unfortunately, it looks like these are off slightly because of the rounding of the corners of the shape-margin box.

shape-image-margin-003
shape-image-margin-002
shape-image-margin-000

@wpt-issue-mover
Copy link

Originally posted as w3c/csswg-test#567 (comment) by @syncbot on 07 Aug 2014, 21:48 UTC:

Automatic validation checks passed.

@wpt-issue-mover wpt-issue-mover mentioned this pull request Mar 31, 2017
Closed
@ghost
Copy link

ghost commented Mar 31, 2017 •
edited by ghost
Loading

View the complete job log.

Firefox (nightly channel)

Testing web-platform-tests at revision d3c7ef2
Using browser at version BuildID 20170406100208; SourceStamp 3c68d659c2b715f811708f043a1e7169d77be2ba
Starting 10 test iterations
All results were stable

All results

6 tests ran
/css/css-display-3/display-contents-dynamic-before-after-001.html
Subtest Results Messages
FAIL
/css/css-display-3/display-contents-dynamic-before-after-first-letter-001.html
Subtest Results Messages
FAIL
/css/css-shapes-1/shape-outside/shape-image/shape-image-margin-000.html
Subtest Results Messages
FAIL
/css/css-shapes-1/shape-outside/shape-image/shape-image-margin-001.html
Subtest Results Messages
FAIL
/css/css-shapes-1/shape-outside/shape-image/shape-image-margin-002.html
Subtest Results Messages
FAIL
/css/css-shapes-1/shape-outside/shape-image/shape-image-margin-003.html
Subtest Results Messages
FAIL

@ghost
Copy link

ghost commented Mar 31, 2017 •
edited by ghost
Loading

View the complete job log.

Chrome (unstable channel)

Testing web-platform-tests at revision d3c7ef2
Using browser at version 59.0.3053.3 dev
Starting 10 test iterations

Unstable results

Test Subtest Results Messages
/css/css-display-3/display-contents-dynamic-before-after-001.html FAIL: 9/10, PASS: 1/10
/css/css-display-3/display-contents-dynamic-before-after-first-letter-001.html FAIL: 9/10, PASS: 1/10
/css/css-shapes-1/shape-outside/shape-image/shape-image-margin-000.html FAIL: 9/10, PASS: 1/10
/css/css-shapes-1/shape-outside/shape-image/shape-image-margin-001.html FAIL: 9/10, PASS: 1/10
/css/css-shapes-1/shape-outside/shape-image/shape-image-margin-002.html FAIL: 9/10, PASS: 1/10
/css/css-shapes-1/shape-outside/shape-image/shape-image-margin-003.html FAIL: 9/10, PASS: 1/10

All results

6 tests ran
/css/css-display-3/display-contents-dynamic-before-after-001.html
Subtest Results Messages
FAIL: 9/10, PASS: 1/10
/css/css-display-3/display-contents-dynamic-before-after-first-letter-001.html
Subtest Results Messages
FAIL: 9/10, PASS: 1/10
/css/css-shapes-1/shape-outside/shape-image/shape-image-margin-000.html
Subtest Results Messages
FAIL: 9/10, PASS: 1/10
/css/css-shapes-1/shape-outside/shape-image/shape-image-margin-001.html
Subtest Results Messages
FAIL: 9/10, PASS: 1/10
/css/css-shapes-1/shape-outside/shape-image/shape-image-margin-002.html
Subtest Results Messages
FAIL: 9/10, PASS: 1/10
/css/css-shapes-1/shape-outside/shape-image/shape-image-margin-003.html
Subtest Results Messages
FAIL: 9/10, PASS: 1/10

@ghost
Copy link

ghost commented Apr 6, 2017

These tests are now available on w3c-test.org

@gsnedders
Copy link
Member Author

Travis failing with Chrome is #5412.

@foolip
Copy link
Member

foolip commented May 10, 2018

@gsnedders can you rebase this so we get a new Travis run? I can review if nobody else shows up.

@gsnedders
Copy link
Member Author

@foolip done

@foolip
Copy link
Member

foolip commented May 10, 2018

Okay, lint is failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astearns astearns Awaiting requested review from astearns

@atanassov atanassov Awaiting requested review from atanassov

@bemjb bemjb Awaiting requested review from bemjb

@kojiishi kojiishi Awaiting requested review from kojiishi

@plinss plinss Awaiting requested review from plinss

@zhorvath zhorvath Awaiting requested review from zhorvath

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
css-shapes stale:awaiting-submitter-response status:needs-reviewers wg-css
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gsnedders @wpt-pr-bot @wpt-issue-mover @foolip @rhauck