314 nil when logging a partial callsign #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Report both callsign and exchange errors in QSO log. - Add argument to IsMyCall to enable random result for lids.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After entering a partial callsign and exchange information, the user will hit
Enterto finish the QSO and log the QSO. The QSO is not logged.This was caused by the logging module only comparing for a perfect match against the caller callsign and not considering the common occurrence of a partially-correct callsign. Code was changed to allow a partially-correct callsign. This allows these QSO to be included in the log as expected.
Checkin notes:
Issue #315 will add improved messages for the partially-correct callsign case. This next review will be posted soon.
Once the second pull request/review is submitted, I will post an engineering build for testing. Stay tuned...