Improve QSO exchanges for partially correct callsigns #317
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running a simulation, sometimes a callsign is copied incorrectly and entered into the Callsign exchange entry field. After hitting Enter, the partial callsign is sent. The calling station will respond with a corrected callsign and optionally the exchange information.
There are two scenarios.
1 - User sends partial call only (using F5 function key)
This condition can easily be created by following these steps:
F5
to send the partial callsign.osNeedCallNr
state.State
osNeedCallNr
The following messages are sent after receiving a partially-correct callsign from the user without an exchange.
The first column shows the original messages and the second column shows the revised messages.
DE <call>
DE <call>
DE <call> <call>
DE <call> <call>
<call> <call>
<call> <call> <exch>
<call> <exch>
The following is the new code showing the responses for this case (
osNeedCallNr
).2 - User sends partial call and their exchange (using Enter key)
This condition can easily be created by following these steps:
Enter
to send the partial callsign and exchangeosNeedCall
state.State
osNeedCall
The following messages are sent after receiving a partially-correct callsign and exchange information from the user.
The first column shows the original messages and the second column shows the revised messages.
Notice the revised messages are now always sending the exchange. I suppose I should leave out the exchange on one of these.
DE <call> <exch>
DE <call> <exch>
DE <call> <call> <exch>
DE <call> <call> <exch>
<call> <call> <exch>
<call> <call> <exch>
<call> <exch>
The following is the new code showing the responses for this case (
osNeedCall
).