Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIL when logging a partial callsign #314

Closed
3 of 4 tasks
Tracked by #350
w7sst opened this issue May 26, 2024 · 3 comments · Fixed by #316
Closed
3 of 4 tasks
Tracked by #350

NIL when logging a partial callsign #314

w7sst opened this issue May 26, 2024 · 3 comments · Fixed by #316
Labels
bug Something isn't working fixed - ready for validation bug is fixed; ready for validation

Comments

@w7sst
Copy link
Owner

w7sst commented May 26, 2024

Description

When working a station and an incorrect/partial callsign is entered, logging this station will result in a NIL error. Ideally, the user should be able to log a partial callsign into the log and the log should report an error showing an invalid callsign.

Steps To Reproduce

  1. Run any contest. I use ARRL FD.
  2. Start Single Call mode
  3. Enter the call, leaving off the last character or modify the last character. This forces a partial callsign.
  4. Hit Enter. This will send the incorrect call and your exchange.
  5. DxStation responds with a corrected callsign and their exchange. Enter the Exchange information.
  6. Hit Enter to log the call. The QSO is entered into the log showing a NIL error.
  7. The DxStation continues to try to complete the QSO. It does not go away. This is also annoying.

Expected behavior

  • Ideally, the User should be able to log a partial callsign into the log to complete the QSO and move onto the next caller.
  • The log should show the callsign correction in the Corrections column (introduced in v1.85).
  • The DxStation should leave the simulation and not continue to call. Perhaps a LID behavior could continue to try to complete the QSO by continuing to send the callsign correction.

Actual Behavior

As mentioned above in the Steps, the QSO is added to the log with a NIL error. The DxStation continues to try to correct their callsign.

Reproduces how often

100%

Version information

  • Morse Runner version: 1.84 and prior
  • OS/Version: Windows 11

Additional context

Tasks

  • Coding
  • Code review
  • Release notes
  • Validation
@w7sst w7sst added the bug Something isn't working label May 26, 2024
@w7sst w7sst added this to the v1.85 - next release milestone May 26, 2024
@w7sst w7sst self-assigned this May 26, 2024
@w7sst w7sst changed the title NIL when trying to log a partial callsign NIL when logging a partial callsign May 26, 2024
@w7sst
Copy link
Owner Author

w7sst commented May 26, 2024

Original

Here is a sample of the original output showing NIL errors after entering a partial/incorrect callsign. You can also see the forced QSO of the persistent DxStation after logging the partial callsign...
image

Revised

Here is a sample of the updated code allowing partial callsigns showing both callsign and exchange errors together...
image

@w7sst
Copy link
Owner Author

w7sst commented May 31, 2024

Here is the link to build v1.85-dev.3 which includes this change.

@w7sst w7sst linked a pull request Jun 9, 2024 that will close this issue
@w7sst w7sst added the fixed - ready for validation bug is fixed; ready for validation label Jun 9, 2024
@w7sst w7sst removed their assignment Jun 9, 2024
@w7sst w7sst mentioned this issue Sep 10, 2024
24 tasks
@w7sst
Copy link
Owner Author

w7sst commented Oct 7, 2024

Closing this one.

@w7sst w7sst closed this as completed Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed - ready for validation bug is fixed; ready for validation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant