Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial suggestions for consistent links to definitions and capitalization #3038

Merged
merged 73 commits into from
Nov 19, 2024
Merged

Editorial suggestions for consistent links to definitions and capitalization #3038

merged 73 commits into from
Nov 19, 2024

Conversation

maryjom
Copy link
Contributor

@maryjom maryjom commented Feb 20, 2023 •
edited by pr-preview bot
Loading

maryjom added 30 commits February 17, 2023 15:32
@maryjom
Use "Web sites" instead of "websites"
3da8ed1 
To be consistent with the rest of the document uses.
@maryjom
Editorial: change "website" to "Web site"
579e8dc 
To be consistent with the rest of the document
@maryjom
Change "web site" to "Web site"
427bdcb 
For consistency with rest of document.
@maryjom
Lower case "art" in "ASCII art"
3fae2d2 
To be consistent in it's use, art shouldn't be capitalized.
@maryjom
Add link to other defined terms used in definition
c569ace
@maryjom
Added link to definition of AT
eb8dd36
@maryjom
Example callout should include bulleted list
6642b57
@maryjom
Add alternate reference "block of text"
2deb386 
In 2 places "block of text" is used. If we add this option, then new SC can link to the definition.
@maryjom
Add link to definition of "blocks of text"
d7b66a6
@maryjom
Add link to definition of "blocks of text"
46a5330
@maryjom
Add link to definition of "user agent"
681fed3
@maryjom
Add link to "contrast ratio"
c6aa5a1
@maryjom
Add link to "focus indicator" definition
4897997
@maryjom
Add link to "functionality" definition
44632ad
@maryjom
Add link to definition to "human languages"
5d0396e
@maryjom
Add "input errors" as alternate spelling/use
14a9fcf 
This is so uses of plural can link to this definition.
@maryjom
Link to definition of "input error"
5b9d388
@maryjom
Add link to definition of "input error"
51bb9bc
@maryjom
Add link to definition of "link purpose"
9a7287b
@maryjom
Add link to definition of "mechanism"
22c66c1
@maryjom
Add plural of "mechanism" for linking
969bd8c
@maryjom
Add link to definition of "mechanism"
f06691f
@maryjom
Add link to "mechanism"
4577ce1
@maryjom
Add link to "mechanism"
50d3282
@maryjom
Add link to "mechanism"
085b329
@maryjom
Add link to definition of "mechanism"
6a6c3af
@maryjom
Add link to definition of "non-text content"
4741929
@maryjom
Add link to definition of "paused"
e074871 
"Paused" definition is used in other instances of the word "pause" where it means the same thing, so this shouldn't cause any problems.
@maryjom
Add link to "pointer input" definition
cc0773c
@maryjom
Add link to definition of "presentation"
cd467f3
mbgower
mbgower reviewed Sep 17, 2024
View reviewed changes
guidelines/terms/20/blocks-of-text.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems appropriate. All uses of "block of text" or "blocks of text" work when considering this as programmatic text.

mbgower
mbgower requested changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@mbgower mbgower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made suggested changes (rejecting the proposed link to the definition) in a few of the files. I'd like those discussed. Otherwise, looks good.

@mbgower mbgower removed their assignment Sep 17, 2024
@mbgower
Copy link
Contributor

mbgower commented Sep 20, 2024 •
edited
Loading

Reviewed and finalized on Sep 20 TF call. Returned to the Errata for CFC column.

@maryjom maryjom mentioned this pull request Oct 28, 2024
Open
16 tasks
@mbgower
Update guidelines/terms/20/blocks-of-text.html
ad93d52 
reverted to address a -1 on the CFC
@gundulaniemann
Copy link
Contributor

Concering definition of 'block of text':
Well, in some contexts one sentence can cover a whole book page. It is typical for German literature written around 100-150 years ago, for example.
So should we stick the the rather grammatical concept of 'one sentence'?

@bruce-usab
Copy link
Contributor

Discussed on TF call 11/8.

Concerning definition of 'block of text'

@gundulaniemann, I think your example reinforces the change Mike made to not linking to the defined term in the one instance.

So should we stick the rather grammatical concept of 'one sentence'?

Please raise this as a separate issue. Of course, you are well of the reluctance to touch normative text! :-)

@kfranqueiro
Copy link
Contributor

Note: While syncing this PR against main, the change to single-pointer was effectively obsoleted by #4070. Whereas this PR had expanded "an input" to "a pointer input" with "pointer input" linking to its definition, #4070 replaced that phrase with "an input modality".

@kfranqueiro kfranqueiro merged commit 1b2d567 into main Nov 19, 2024
5 checks passed
@kfranqueiro kfranqueiro deleted the mjm-wcag-editorial-suggestions branch November 19, 2024 18:18
@alastc alastc added the ErratumRaised Potential erratum for a Recommendation label Dec 16, 2024
kfranqueiro pushed a commit that referenced this pull request Dec 18, 2024
@maryjom @kfranqueiro
Editorial suggestions for consistent links to definitions and capital…
106982b 
…ization (#3038)

Co-authored-by: Francis Storr <[email protected]>
Co-authored-by: Kenneth G. Franqueiro <[email protected]>
Co-authored-by: Mike Gower <[email protected]>
(cherry picked from commit 1b2d567)
kfranqueiro pushed a commit that referenced this pull request Dec 18, 2024
@maryjom @kfranqueiro
Editorial suggestions for consistent links to definitions and capital…
5ef3dee 
…ization (#3038)

Co-authored-by: Francis Storr <[email protected]>
Co-authored-by: Kenneth G. Franqueiro <[email protected]>
Co-authored-by: Mike Gower <[email protected]>
(cherry picked from commit 1b2d567)
kfranqueiro added a commit that referenced this pull request Dec 19, 2024
@kfranqueiro
Remove term reference from #3038 backport that doesn't exist in 2.1
85e2068
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruce-usab bruce-usab bruce-usab approved these changes

@mbgower mbgower mbgower approved these changes

@WilcoFiers WilcoFiers WilcoFiers left review comments

@kfranqueiro kfranqueiro kfranqueiro approved these changes

@dbjorge dbjorge dbjorge left review comments

@alastc alastc alastc left review comments

@patrickhlauke patrickhlauke patrickhlauke approved these changes

Assignees
No one assigned
Labels
Editorial ErratumRaised Potential erratum for a Recommendation Normative
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.