Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial suggestions for consistent links to definitions and capitalization #3038
Editorial suggestions for consistent links to definitions and capitalization #3038
Changes from 61 commits
3da8ed1
579e8dc
427bdcb
3fae2d2
c569ace
eb8dd36
6642b57
2deb386
d7b66a6
46a5330
681fed3
c6aa5a1
4897997
44632ad
5d0396e
14a9fcf
5b9d388
51bb9bc
9a7287b
22c66c1
969bd8c
f06691f
4577ce1
50d3282
085b329
6a6c3af
4741929
e074871
cc0773c
cd467f3
85ef905
f3f645c
be25fca
4b2a7e4
70ce5f2
8556b6a
c063946
d266876
6e9d0d4
fb7d01e
b2af915
b716675
dc02557
6678982
02a4fba
307b91a
d0d3b39
f6aa1f0
cfeb046
1c61c8a
3a27a71
c02324f
2815923
ea4ba29
fedb967
760dcb5
655930f
60d8273
ec929db
d51622c
68d26c2
083f39a
18ff303
84267c2
9744fa5
9e69203
580eccc
2acec12
735ee3c
ea8ef6b
ac8a6fc
ad93d52
4efd0cf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Focus indicator is a definition added in WCAG 2.2. So in 2.2 a link to "focus indicator" can exist, but the 2.1 (and 2.0) version of the same file cannot have that link since the definition doesn't exist. @kfranqueiro and @alastc can our model now support this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as this is only happening within the
guidelines
folder I think we're okay; the plan for building 2.1 is to use a snapshot of the 2.1 TR so it won't be looking at that folder in the main branch (which contains 2.2-specific things).If you discover anything like this directly within the source of Understanding pages, that would definitely be worth flagging because we would need to conditionalize it somehow. (Currently the only conditionalization I'm aware of in that regard is for the "New in WCAG 2.2" callouts.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally don't see any "win" by adding the link, but it doesn't seem to create a problem changing it either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there was no definition of "state" in 2.0; it's there in 2.1, but not marked as "New". @alastc I'm assuming that as long as this link exists in 2.1 and 2.2, we're okay, since we wouldn't be touching 2.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems appropriate. All uses of "block of text" or "blocks of text" work when considering this as programmatic text.