Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify name for recommended mark for feature usag based on feedback #108

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

anniesullie
Copy link
Collaborator

@anniesullie anniesullie commented Nov 14, 2023

People found mark_use_counter confusing and recommended a name that's meaningful outside of Chrome's "use counter" terminology. A follow up on #105


Preview | Diff

Copy link

@ksylor ksylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for changing the name to something easier to understand!

Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anniesullie anniesullie merged commit 9508b11 into gh-pages Nov 14, 2023
2 checks passed
alxhub pushed a commit to angular/angular that referenced this pull request Dec 13, 2023
This commit updates the name of the 'performance.mark'
counter used to track feature usage. It now matches
the name agreed upon by W3C for this use case:
w3c/user-timing#108

PR Close #53542
alxhub pushed a commit to angular/angular that referenced this pull request Dec 13, 2023
This commit updates the name of the 'performance.mark'
counter used to track feature usage. It now matches
the name agreed upon by W3C for this use case:
w3c/user-timing#108

PR Close #53542
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
This commit updates the name of the 'performance.mark'
counter used to track feature usage. It now matches
the name agreed upon by W3C for this use case:
w3c/user-timing#108

PR Close angular#53542
rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
This commit updates the name of the 'performance.mark'
counter used to track feature usage. It now matches
the name agreed upon by W3C for this use case:
w3c/user-timing#108

PR Close angular#53542
danieljancar pushed a commit to danieljancar/angular that referenced this pull request Jan 26, 2024
This commit updates the name of the 'performance.mark'
counter used to track feature usage. It now matches
the name agreed upon by W3C for this use case:
w3c/user-timing#108

PR Close angular#53542
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
This commit updates the name of the 'performance.mark'
counter used to track feature usage. It now matches
the name agreed upon by W3C for this use case:
w3c/user-timing#108

PR Close angular#53542
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants