Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify name for recommended mark for feature usag based on feedback #108

Merged
merged 1 commit into from
Nov 14, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,7 @@ <h2>Recommended mark names</h2>
<dt>"<dfn class="export">mark_interactive</dfn>"</dt>
<dd>The time when the page is considered interactive to an end-user as
marked by the developer in their application.</dd>
<dt>"<dfn class="export">mark_use_counter</dfn>"</dt>
<dt>"<dfn class="export">mark_feature_usage</dfn>"</dt>
<dd>Mark the usage of a feature which may impact performance so that
tooling and analytics can take it into account. The <a data-link-for="PerformanceMark">detail</a>
metadata can contain any useful information about the feature, including:
Expand All @@ -453,7 +453,7 @@ <h2>Recommended mark names</h2>
whether it helped improve performance.
</p>
<pre class="example">
performance.mark('mark_use_counter', {
performance.mark('mark_feature_usage', {
'detail': {
'feature': 'ImageOptimizationComponent',
'framework': 'FancyJavaScriptFramework'
Expand Down
Loading