Get back to RespecDocWriter to generate specs #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making latest version of Respec run under JSDOM is too much of a maintenance burden in the end: https://github.com/w3c/respec/issues/1469#issuecomment-546790835 This update makes Reffy use respecDocWriter (which uses the headless browser Puppeteer under the hoods) again. This allows to run the latest version of Respec. JSDOM is still used to load specifications that do not use Respec and to detect when a specification uses Respec. Note the code no longer runs external scripts when it loads specifications: that seems unneeded in practice. The code still contains minimal monkey patching for JSDOM so because a number of specifications do have inline scripts that call `window.matchMedia`, which JSDOM does not support. This will fix #134.
|
@foolip FYI, this move to the latest version of Respec will trigger a few updates to IDL exports because Respec formats WebIDL snippets slightly differently to ease readability. |
This was referenced Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making latest version of Respec run under JSDOM is too much of a maintenance burden in the end:
https://github.com/w3c/respec/issues/1469#issuecomment-546790835
This update makes Reffy use respecDocWriter (which uses the headless browser Puppeteer under the hoods) again. This allows to run the latest version of Respec.
JSDOM is still used to load specifications that do not use Respec and to detect when a specification uses Respec. Note the code no longer runs external scripts when it loads specifications: that seems unneeded in practice.
The code still contains minimal monkey patching for JSDOM so because a number of specifications do have inline scripts that call
window.matchMedia, which JSDOM does not support.This will fix #134.
Note I ran local crawls to check the results. This triggers a number of updates to the list of references that get extracted, but they all seem correct (and long overdue). It triggers some formatting updates to IDL extracts but no substantive changes. Only current issue is that some specs are now flagged by Respec as purely informative because they lack a conformance section and Reffy thus fails to extract WebIDL content for now for these specs, see discussion in:
https://github.com/w3c/respec/issues/2580
(I prepared PR against these specs)