Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update interfaces/pointerlock.idl #20383

Conversation

autofoolip
Copy link
Contributor

This PR was automatically created by a bot.

Before merging, please check that any tests that depend on the updated IDL files still work.

If additional changes are needed, please manually create another PR based on this one.

See the README for how the IDL files in this directory are used.


Source: https://github.com/tidoust/reffy-reports/blob/fea9670/ed/idl/pointerlock.idl
Build: https://travis-ci.org/tidoust/reffy-reports/builds/615198653

@stephenmcgruer
Copy link
Contributor

This one seems strange; can you have a look @foolip ? A space between Element and ? is weird to me, though it is in the original spec (and seems to have been for years, not sure why reffy is picking it up now).

@foolip
Copy link
Member

foolip commented Nov 22, 2019

@stephenmcgruer https://w3c.github.io/pointerlock/ uses ReSpec, and I've seen whitespace changes in the past when ReSpec changes how it parses Web IDL. I've commented on w3c/reffy#196 (comment).

@foolip
Copy link
Member

foolip commented Nov 22, 2019

OK, here's what happened. w3c/reffy#198 bumped the version of respec used by reffy, and w3c/webref@fea9670 was the first reffy-reports update after that, bringing in a bunch of whitespace changes.

To get all those boring changes out of the way, I'll create a PR to sync just whitespace for lots of IDL files.

foolip added a commit that referenced this pull request Nov 22, 2019
A recent respec update caused a lot of whitespace changes:
#20383 (comment)

Sync them all manually to get them out of the way.

Source: https://github.com/tidoust/reffy-reports/tree/b60317f12fda1169cc3d0f9b320735d11ac47203/ed/idl
@tidoust
Copy link
Contributor

tidoust commented Nov 22, 2019

Actually, these changes were more triggered by w3c/reffy#195 but reason is the same: Reffy was stuck to a now pretty old version of Respec before and Respec has indeed adjusted its WebIDL formatting rules since then.

@foolip
Copy link
Member

foolip commented Nov 22, 2019

@tidoust I linked to w3c/reffy#198 and not w3c/reffy#195 but I guess the root cause is the same in any case :)

stephenmcgruer pushed a commit that referenced this pull request Nov 22, 2019
@foolip
Copy link
Member

foolip commented Nov 22, 2019

With #20393 this should be closed automatically when reffy-reports sync next runs. Waiting for that rather than closing manually to ensure it works.

@autofoolip autofoolip closed this Nov 23, 2019
@autofoolip autofoolip deleted the reffy-reports/pointerlock branch November 23, 2019 00:42
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Nov 29, 2019
…m reffy-reports, a=testonly

Automatic update from web-platform-tests
Update interface/ whitespace changes from reffy-reports (#20393)

A recent respec update caused a lot of whitespace changes:
web-platform-tests/wpt#20383 (comment)

Sync them all manually to get them out of the way.

Source: https://github.com/tidoust/reffy-reports/tree/b60317f12fda1169cc3d0f9b320735d11ac47203/ed/idl
--

wpt-commits: e030f3cdd965324531aac2c9c432b605a2f4962e
wpt-pr: 20393
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request Nov 29, 2019
…m reffy-reports, a=testonly

Automatic update from web-platform-tests
Update interface/ whitespace changes from reffy-reports (#20393)

A recent respec update caused a lot of whitespace changes:
web-platform-tests/wpt#20383 (comment)

Sync them all manually to get them out of the way.

Source: https://github.com/tidoust/reffy-reports/tree/b60317f12fda1169cc3d0f9b320735d11ac47203/ed/idl
--

wpt-commits: e030f3cdd965324531aac2c9c432b605a2f4962e
wpt-pr: 20393
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Nov 30, 2019
…m reffy-reports, a=testonly

Automatic update from web-platform-tests
Update interface/ whitespace changes from reffy-reports (#20393)

A recent respec update caused a lot of whitespace changes:
web-platform-tests/wpt#20383 (comment)

Sync them all manually to get them out of the way.

Source: https://github.com/tidoust/reffy-reports/tree/b60317f12fda1169cc3d0f9b320735d11ac47203/ed/idl
--

wpt-commits: e030f3cdd965324531aac2c9c432b605a2f4962e
wpt-pr: 20393

UltraBlame original commit: 0948e3db8373557c66dda4f5aaafef0d0196e074
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Nov 30, 2019
…m reffy-reports, a=testonly

Automatic update from web-platform-tests
Update interface/ whitespace changes from reffy-reports (#20393)

A recent respec update caused a lot of whitespace changes:
web-platform-tests/wpt#20383 (comment)

Sync them all manually to get them out of the way.

Source: https://github.com/tidoust/reffy-reports/tree/b60317f12fda1169cc3d0f9b320735d11ac47203/ed/idl
--

wpt-commits: e030f3cdd965324531aac2c9c432b605a2f4962e
wpt-pr: 20393

UltraBlame original commit: 0948e3db8373557c66dda4f5aaafef0d0196e074
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Nov 30, 2019
…m reffy-reports, a=testonly

Automatic update from web-platform-tests
Update interface/ whitespace changes from reffy-reports (#20393)

A recent respec update caused a lot of whitespace changes:
web-platform-tests/wpt#20383 (comment)

Sync them all manually to get them out of the way.

Source: https://github.com/tidoust/reffy-reports/tree/b60317f12fda1169cc3d0f9b320735d11ac47203/ed/idl
--

wpt-commits: e030f3cdd965324531aac2c9c432b605a2f4962e
wpt-pr: 20393

UltraBlame original commit: 0948e3db8373557c66dda4f5aaafef0d0196e074
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants