Crawl breaks when Respec v23.7.2 is used #134
Labels
Comments
tidoust
changed the title
tidoust
added a commit
that referenced
this issue
Dec 3, 2018
tidoust
added a commit
that referenced
this issue
Jul 25, 2019
Reffy gladly used the IDL index at the end of the spec to extract the IDL definitions, but ReSpec generates this IDL index on-the-fly and we're currently stuck to an old version of ReSpec (see #134), which chokes on recent WebIDL constructs and fails to include them in the IDL index, as described in: w3c/webref#34 With this update, Reffy now ignores the IDL index and extracts IDL definitions from main spec sections, and not from the IDL index appendix. Useless leading spaces are now discarded as well (#130).
|
Provided #166 gets fixed, we should be able to switch to latest version of Respec when https://github.com/w3c/respec/pull/2187 gets merged. |
tidoust
added a commit
that referenced
this issue
Nov 21, 2019
Making latest version of Respec run under JSDOM is too much of a maintenance burden in the end: https://github.com/w3c/respec/issues/1469#issuecomment-546790835 This update makes Reffy use respecDocWriter (which uses the headless browser Puppeteer under the hoods) again. This allows to run the latest version of Respec. JSDOM is still used to load specifications that do not use Respec and to detect when a specification uses Respec. Note the code no longer runs external scripts when it loads specifications: that seems unneeded in practice. The code still contains minimal monkey patching for JSDOM so because a number of specifications do have inline scripts that call `window.matchMedia`, which JSDOM does not support. This will fix #134.
tidoust
added a commit
that referenced
this issue
Nov 21, 2019
Making latest version of Respec run under JSDOM is too much of a maintenance burden in the end: https://github.com/w3c/respec/issues/1469#issuecomment-546790835 This update makes Reffy use respecDocWriter (which uses the headless browser Puppeteer under the hoods) again. This allows to run the latest version of Respec. JSDOM is still used to load specifications that do not use Respec and to detect when a specification uses Respec. Note the code no longer runs external scripts when it loads specifications: that seems unneeded in practice. The code still contains minimal monkey patching for JSDOM so because a number of specifications do have inline scripts that call `window.matchMedia`, which JSDOM does not support. This will fix #134.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
and others
Via web-platform-tests/wpt#14333 (comment)
That could be due to JSDOM monkeypatch and new "Cannot clone an attribute that does not belong to a document!" error reported during crawl.
The text was updated successfully, but these errors were encountered: