-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition: Prohibit naming of elements #402
Conversation
Adds new naming requirements section. Additional work and review needed. Need to indicate all elements with implicit roles which prohibit naming closes #147
hardened the code comment
* define elements which are prohibited from being named so long as they expose their implicit semantics * introduce the concepts of prohibited attributes and provide a def for 'naming prohibited' in the spec
This PR needs #392 to be merged first. But this is now ready to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question there about "from authors" vs "by authors". if the former is used elsewhere, fair enough keep it. but otherwise it would read better as the latter I'd say
@patrickhlauke ”name from” is on purpose. It’s what aria says |
aha, in that case, as awks as it sounds...make it so |
same rules as caption and label
these either represent their children, per other text-level semantics, or are important in the structure of a `ruby` element. These shouldn't be named... more testing needed to determine the impact aria can have on these in general.
should push the test to the main branch instead.
this will instead be covered in resolving #407
* Set implicit role mappings to `generic` Implements changes from w3c/html-aria#425 * Set address' element implicit role to `group` Implements change from w3c/html-aria@ba30b83 * Assign ARIA 1.2 roles to elements Implements changes from w3c/html-aria#392 * Make `<section>` with inaccessible name's implicit role to be `generic` See w3c/html-aria#475 * Set implicit ARIA mapping for <s> element to `deletion` See w3c/html-aria#469 * Set `form` as the only implicit ARIA role for the form element See w3c/html-aria#402
This has been changed in the ARIA spec in w3c/html-aria#402.
This has been changed in the ARIA spec in w3c/html-aria#402. See also testing-library/dom-testing-library#1293
This has been changed in the ARIA spec in w3c/html-aria#402. See also testing-library/dom-testing-library#1293
This has been changed in the ARIA spec in w3c/html-aria#402. See also testing-library/dom-testing-library#1293
directly reference the following PRs in the changelog, and prepend each entry with the appropriate 'label' related to w3c/html-aria#419 - w3c/html-aria#352 - w3c/html-aria#367 (and follow on [commit](w3c/html-aria@9cc2c0a)) - w3c/html-aria#360 - w3c/html-aria#353 - w3c/html-aria#372 - w3c/html-aria#402 - w3c/html-aria#404 - w3c/html-aria#403 - w3c/html-aria#396 - w3c/html-aria#391 - w3c/html-aria#369 - w3c/html-aria#381
Adds new naming requirements section.
Additional work and review needed.
Need to indicate all elements with implicit roles which prohibit naming
closes #147
test case
axe largely supports this rule, but for a few elements.
w3c validator partially supports this rule, but needs to change warnings to errors, and needs to add a check for aria-labelledby (only checks for aria-label right now)
ibm and
arc toolkitdo not yet support the naming prohibited rule (arc toolkit has implemented this rule)HTML validator
IBM equal access accessibility checker
axe-core (supported but for 2 elements)
ARC toolkit
NOTE: see follow on issue #407 concerning the
rp
element, which has been removed from this PR.Preview | Diff