-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition: update allowances for area no href #360
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes issue #325
scottaohara
added
the
needs implementation commitment
Cannot merge into spec until implementations in conformance checkers has been confirmed.
label
Oct 5, 2021
This was referenced Oct 6, 2021
scottaohara
added a commit
to scottaohara/WAI-ARIA-Usage
that referenced
this pull request
Oct 6, 2021
updates allowances per the ARIA in HTML PR - w3c/html-aria#360 `area` without `href` can allow for `role=button` or `link`.
patrickhlauke
approved these changes
Oct 7, 2021
Just had a thought... maybe we can prefix the commit messages with "correction:" and "addition:"? That could also help us identify what's what. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
scottaohara
changed the title
update allowances for area no href
Addition: update allowances for area no href
Nov 8, 2021
scottaohara
added
Meets 2 implementations req
Indicates that a spec change has met the necessary 2 implementations needed to merge.
and removed
needs implementation commitment
Cannot merge into spec until implementations in conformance checkers has been confirmed.
labels
Nov 16, 2021
scottaohara
added a commit
that referenced
this pull request
May 19, 2022
pkra
pushed a commit
to w3c/aria
that referenced
this pull request
May 20, 2024
directly reference the following PRs in the changelog, and prepend each entry with the appropriate 'label' related to w3c/html-aria#419 - w3c/html-aria#352 - w3c/html-aria#367 (and follow on [commit](w3c/html-aria@9cc2c0a)) - w3c/html-aria#360 - w3c/html-aria#353 - w3c/html-aria#372 - w3c/html-aria#402 - w3c/html-aria#404 - w3c/html-aria#403 - w3c/html-aria#396 - w3c/html-aria#391 - w3c/html-aria#369 - w3c/html-aria#381
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Meets 2 implementations req
Indicates that a spec change has met the necessary 2 implementations needed to merge.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes issue #325
This update allows authors to specify the
link
orbutton
roles on anarea
with nohref
attribute.Any more complex widget, particularly any that would need to convey a visual state or updated styling, would be far more practical for authors to create another accessible control instead. As these elements do not allow nested content (and even CSS pseudo element content appears in a different location than where the
area'
s coordinates place it, no container-type role would make sense here either.Ideally, authors would be using a
tabindex
on these elements when specifying a role.... but as there could be situations where a role needs to be conveyed, but it is not necessary to make the particular element keyboard accessible (alternate mechanism available), the requirement for including atabindex
was left off this PR. Additionally, we make no such requirements for other widget roles, so on second thought it seemed out of place to require one for this role.Need at least two checkers to accept this change before we can merge.
Preview | Diff