-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new aria 1.2 roles #392
Conversation
closes #200 Adds `blockquote`, `caption`, `code`, `deletion`, `emphasis`, `generic`, `insertion`, `meter`, `paragraph`, `strong`, `subscript`, `superscript`, `time`. Updates links from referencing ARIA 1.1 to ARIA 1.2 changes / corrects `dd` and `dt` to not reference an ARIA role, as `definition` and `term` were corrected in ARIA 1.2 to not be associated with these elements. TODO: more elements map to `generic`. These are non-normative updates, since these roles are defined in ARIA 1.2/CORE AAM and the HTML mappings in HTML AAM, respectively.
Waiting on merging of w3c/html-aam#364 before finishing this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes/questions - see comments (not sure why it's now marking them as outdated...unless i've commented on some previous state/github wasn't showing me the latest, not sure)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy for this to be merged, but worth opening a separate PR to have another look at that role=Main
issue (as if it's making a point about lowercase, it buries the lede/doesn't actually explain it)
The only thing that will be out of sync with merging this PR is the |
* Set implicit role mappings to `generic` Implements changes from w3c/html-aria#425 * Set address' element implicit role to `group` Implements change from w3c/html-aria@ba30b83 * Assign ARIA 1.2 roles to elements Implements changes from w3c/html-aria#392 * Make `<section>` with inaccessible name's implicit role to be `generic` See w3c/html-aria#475 * Set implicit ARIA mapping for <s> element to `deletion` See w3c/html-aria#469 * Set `form` as the only implicit ARIA role for the form element See w3c/html-aria#402
closes #200
Adds
blockquote
,caption
,code
,deletion
,emphasis
,generic
,insertion
,meter
,paragraph
,strong
,subscript
,superscript
,time
.Updates links from referencing ARIA 1.1 to ARIA 1.2
changes / corrects
dd
anddt
to not reference an ARIA role, asdefinition
andterm
were corrected in ARIA 1.2 to not be associated with these elements.These are non-normative updates, since these roles are defined in ARIA 1.2/CORE AAM and the HTML mappings in HTML AAM, respectively.
TODO:
more elements map to
generic
.Additionally, there needs to be some content added to the spec to indicate that(issue to update 'any role' #358).generic
is a role authors SHOULD NOT be using, per the ARIA spec. This could be tacked onto the 'any role' definitionrelated to resolving HTML AAM w3c/html-aam#373
Preview | Diff