-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates needed for button example page #189
Comments
If the task force has agreed to not include anti-patterns, then the non-compliant pattern "a element with href="#"" should be deleted including the code example at the bottom of the page. |
I am not comfortable with the wording of the following note so I am removing it for now, and I am adding a task to the above checklist to address this point.
If we are going to have a note like this, the note should either include a crisp statement of rationale or link to an explanation. |
Does the mute button need to change the accessible when it toggles from pressed to unpressed (e.g. mute to unmute)? |
@jongund wrote:
No, in fact, the design pattern explicitly warns people not to do that. We may want to remind of them of that on the example page in the properties table. |
The first button example "Print Page" doesn't specify |
@mcking65, can you review the fix? |
@mdahamiwal thanks. |
Per today's discussion in APG task force meeting, adding the following two items to the checklist of required updates:
|
Updated button example to fix problems listed in issue #189.
Resolved in 3/13/2017 meeting not to add a note discouraging button role Minutes of March 13, 2017 teleconference: |
Modified examples/button/button.html: 1. Add link to review issue 316. 2. Fix href of links to button design pattern. 3. Revise wording of introduction. 4. Add links to menubutton examples. 5. Add elements from template that provide separators that mark start and end of example for screen reader users. 6. Remove two H2 headings for the buttons and replace with a single H2 for the example section. 7. Editorial revisions to keyboard table. 8. Editorial revisions to states and properties table.
@jongund, while working on editorial clean up, I noticed that the svg for the toggle is inline but not part of the example div. Since it is a part of the example, it should either be inside that div, which might be distracting to people reading the html, or in an svg file. I sort of prefer the latter for both clarity and consistency with other examples. |
Fixed |
Under Toggle Button, the following statement is present: Copied forward to issue #316 |
I moved the SVG to an external file |
All updates are now complete and being reviewed in issue 316. Closing. |
The button example page
needs the following changes.
The text was updated successfully, but these errors were encountered: