Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates needed for button example page #189

Closed
7 tasks done
mcking65 opened this issue Dec 7, 2016 · 14 comments
Closed
7 tasks done

Updates needed for button example page #189

mcking65 opened this issue Dec 7, 2016 · 14 comments
Assignees
Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies.

Comments

@mcking65
Copy link
Contributor

mcking65 commented Dec 7, 2016

The button example page
needs the following changes.

  • Update to use the current example template
  • Make the toggle button with anchor instead of span.
  • Drop the 3rd "show alert" button example.
  • Remove the "non-compliant" example or change it to follow the pattern; the task force has agreed to not include anti-patterns.
  • Change the title to "Button Examples"
  • Fix misspellings.
  • Task force decision on whether a note discouraging use of role button in favor of html buttons is warranted. If yes, agree on a wording.
@mcking65 mcking65 added this to the 1.1 PR milestone Dec 7, 2016
@mcking65 mcking65 added editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. needs edits labels Dec 7, 2016
@annabbott
Copy link

annabbott commented Dec 8, 2016

If the task force has agreed to not include anti-patterns, then the non-compliant pattern "a element with href="#"" should be deleted including the code example at the bottom of the page.

@mcking65
Copy link
Contributor Author

I am not comfortable with the wording of the following note so I am removing it for now, and I am adding a task to the above checklist to address this point.

Note: When using HTML, use the button element.
It is recommended that authors not re-purpose other elements to create buttons.

If we are going to have a note like this, the note should either include a crisp statement of rationale or link to an explanation.

mcking65 added a commit that referenced this issue Dec 12, 2016
Merge changes to improve the button example page for issue #189.
@jongund
Copy link
Contributor

jongund commented Dec 12, 2016

Does the mute button need to change the accessible when it toggles from pressed to unpressed (e.g. mute to unmute)?

@mcking65
Copy link
Contributor Author

@jongund wrote:

Does the mute button need to change the accessible when it toggles from pressed to unpressed (e.g. mute to unmute)?

No, in fact, the design pattern explicitly warns people not to do that. We may want to remind of them of that on the example page in the properties table.

@mdahamiwal
Copy link
Contributor

The first button example "Print Page" doesn't specify tabindex and is not part of tab order.

@mdahamiwal
Copy link
Contributor

@mcking65, can you review the fix?

@jnurthen
Copy link
Member

@mdahamiwal thanks.

@mcking65 mcking65 modified the milestones: Feb 2017 Heartbeat Draft, 1.1 PR Jan 7, 2017
@mcking65
Copy link
Contributor Author

mcking65 commented Jan 9, 2017

Per today's discussion in APG task force meeting, adding the following two items to the checklist of required updates:

  1. Make the toggle button with anchor instead of span.
  2. Drop the 3rd "show alert" button example.

mcking65 added a commit that referenced this issue Jan 23, 2017
Updated button example to fix problems listed in issue #189.
@jnurthen
Copy link
Member

jnurthen commented Mar 13, 2017

Resolved in 3/13/2017 meeting not to add a note discouraging button role

Minutes of March 13, 2017 teleconference:
https://www.w3.org/2017/03/13-aria-apg-minutes.html

mcking65 added a commit that referenced this issue Mar 14, 2017
Modified examples/button/button.html:
1. Add link to review issue 316.
2. Fix href of links to button design pattern.
3. Revise wording of introduction.
4. Add links to menubutton examples.
5. Add elements from template that provide separators that mark start and end of example for screen reader users.
6. Remove two H2 headings for the buttons and replace with a single H2 for the example section.
7. Editorial revisions to keyboard table.
8. Editorial revisions to states and properties table.
@mcking65
Copy link
Contributor Author

@jongund, while working on editorial clean up, I noticed that the svg for the toggle is inline but not part of the example div. Since it is a part of the example, it should either be inside that div, which might be distracting to people reading the html, or in an svg file. I sort of prefer the latter for both clarity and consistency with other examples.

@jongund
Copy link
Contributor

jongund commented Mar 15, 2017

Fixed

@annabbott
Copy link

annabbott commented Mar 15, 2017

Under Toggle Button, the following statement is present:
Mute button uses a a element.
Suggested edit:
Mute button uses an a element.

Copied forward to issue #316

@jongund
Copy link
Contributor

jongund commented Mar 20, 2017

I moved the SVG to an external file

@mcking65
Copy link
Contributor Author

All updates are now complete and being reviewed in issue 316. Closing.

mcking65 added a commit that referenced this issue Mar 21, 2017
The Authoring Practices Task Force review process is now complete for this example.
The revisions prescribed by  issue #189 and reviewed in issue #316 are complete.

Modified examples/button/button.html: Close task force review process by removing link to review issue #316.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies.
Development

No branches or pull requests

5 participants