updated button example per #189 issue #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnurthen
reviewed
Dec 12, 2016
| The following examples are composed using a <code>div</code> and <code>span</code> elements | ||
| functioning as a native <code>button</code> element, and an <code>a</code> element that functions as a | ||
| The following examples are composed using a <code>div</code> and <code>a</code> elements | ||
| functioning as a native <code>button</code> element, and an <code>span</code> element that functions as a |
There was a problem hiding this comment.
please change to
and a <code>span</code> element
|
James,
I made the change.
Jon
From: James Nurthen <[email protected]<mailto:[email protected]>>
Reply-To: w3c/aria-practices <[email protected]<mailto:[email protected]>>
Date: Sunday, December 11, 2016 at 7:42 PM
To: w3c/aria-practices <[email protected]<mailto:[email protected]>>
Cc: Jon Gunderson <[email protected]<mailto:[email protected]>>, Author <[email protected]<mailto:[email protected]>>
Subject: Re: [w3c/aria-practices] updated button example per #189 issue (#209)
@jnurthen commented on this pull request.
________________________________
In examples/button/button.html<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_w3c_aria-2Dpractices_pull_209-23pullrequestreview-2D12382253&d=DQMCaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=REZD8fc2AwufInstfW3L5jSLVS8bjZtAodDOhat7yAI&m=3f6fMDFqHYbroz0ue2kF04qlxHQbofdhOJOf0pMqPhw&s=nGHmGFnyawQ7wD4C5cnuKe9pyoD3A_VoX8dGFIgkjkA&e=>:
@@ -15,8 +15,8 @@
<p>
Creating Buttons using <code>role=button</code> following the <a href="../../#h-button">Button Design Patten</a>.
- The following examples are composed using a <code>div</code> and <code>span</code> elements
- functioning as a native <code>button</code> element, and an <code>a</code> element that functions as a
+ The following examples are composed using a <code>div</code> and <code>a</code> elements
+ functioning as a native <code>button</code> element, and an <code>span</code> element that functions as a
please change to
and a <code>span</code> element
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_w3c_aria-2Dpractices_pull_209-23pullrequestreview-2D12382253&d=DQMCaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=REZD8fc2AwufInstfW3L5jSLVS8bjZtAodDOhat7yAI&m=3f6fMDFqHYbroz0ue2kF04qlxHQbofdhOJOf0pMqPhw&s=nGHmGFnyawQ7wD4C5cnuKe9pyoD3A_VoX8dGFIgkjkA&e=>, or mute the thread<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ABcE7IH6ZvrcuuyS13XUC4dHK53b6-5FUlks5rHKZogaJpZM4LKBEc&d=DQMCaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=REZD8fc2AwufInstfW3L5jSLVS8bjZtAodDOhat7yAI&m=3f6fMDFqHYbroz0ue2kF04qlxHQbofdhOJOf0pMqPhw&s=U__SRSv6ELX50ctDbOtpvQfbgB26gW5nhz-Q2YCgOcQ&e=>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.