Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review updates to button examples #316

Closed
3 tasks done
mcking65 opened this issue Mar 14, 2017 · 4 comments
Closed
3 tasks done

Review updates to button examples #316

mcking65 opened this issue Mar 14, 2017 · 4 comments
Assignees
@jnurthen @a11ydoer @annabbott
Labels
Example Page Related to a page containing an example implementation of a pattern
Milestone
Jan 2017 Clean Up

Comments

@mcking65
Copy link
Contributor

mcking65 commented Mar 14, 2017 •
edited
Loading

Significant changes to the
button example page
were made for issue #189. It is ready for review.

Reviews Requested as of March 14, 2017
@mcking65 mcking65 added this to the Jan 2017 Clean Up milestone Mar 14, 2017
@mcking65 mcking65 added Example Page Related to a page containing an example implementation of a pattern Needs Review labels Mar 14, 2017
@annabbott
Copy link

Copied in from issue #189.
Under Toggle Button, the following statement is present:
Mute button uses a a element.
Suggested edit:
Mute button uses an a element.

@annabbott annabbott mentioned this issue Mar 15, 2017
Closed
7 tasks
mcking65 added a commit that referenced this issue Mar 16, 2017
@mcking65
Button Example: Fix Grammar Error for Issue #316
3591c38 
Per comment by @annabbott in issue #316, Modified examples/button/button.html:
changed "a `A` element" to "an `A` element".
@jnurthen
Copy link
Member

Looks good

@a11ydoer
Copy link
Contributor

This example looks clear and simple.

mcking65 added a commit that referenced this issue Mar 21, 2017
@mcking65
Button Example: Completed Task Force Reviews
ec52a5e 
The Authoring Practices Task Force review process is now complete for this example.
The revisions prescribed by  issue #189 and reviewed in issue #316 are complete.

Modified examples/button/button.html: Close task force review process by removing link to review issue #316.
@mcking65
Copy link
Contributor Author

Task force reviews are complete for this example. Thank you team! Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jnurthen jnurthen

@a11ydoer a11ydoer

@annabbott annabbott

Labels
Example Page Related to a page containing an example implementation of a pattern
Projects
Command, Toggle, Menu, and Disclosure Button Patterns and Examples Development Project
Status: Complete
Milestone
Jan 2017 Clean Up
Development

No branches or pull requests
4 participants
@jnurthen @mcking65 @a11ydoer @annabbott