Specify the error code for failures when reading a value from disk #430
Conversation
abhishek-shanthkumar
requested review from
asutherland,
michaelwasserman and
SteveBeckerMSFT
abhishek-shanthkumar
requested review from
inexorabletash
and removed request for
michaelwasserman
There was a problem hiding this comment.
Looks great! Thank you for your patience.
Two last non-normative things:
- Add a note into the Revision History section, referencing the issue.
- Add yourself to the Acknowledgements section
(Normally I might do these as a follow-up PR but it's easiest if you do it - thank you!!!)
|
Thank you for the review! I've updated these two sections, please take a look. |
|
Thank you! This wasn't discussed at TPAC. |
|
Ah, that's right - inspired by Gecko. I'll go ahead and merge. |
) SHA: 020487e Reason: push, by inexorabletash Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
| @@ -1866,6 +1866,13 @@ usage. | |||
| not be found. | |||
| </td> | |||
| </tr> | |||
| <tr> | |||
| <td>{{NotReadableError}}</td> | |||
There was a problem hiding this comment.
Might be worth mentioning that this is considered a "permanent" loss or that the data is "irrecoverable"?
(Sorry for late review)
There was a problem hiding this comment.
Thanks, I'll update this in a follow-up PR.
|
Speaking of late reviews, I noticed that at least some errors are now StructuredSerialize-able. So making success/failure more explicit should be done. Follow-up PRs! |
Could you elaborate a bit on what you mean? Were |
Not until 2019. whatwg/webidl#732 Which is a long time ago, but this spec is pretty old. :) |
abhishek-shanthkumar
deleted the
abhishek-shanthkumar/value-read-error
branch
As a followup to crrev.com/c/5831673 and w3c/IndexedDB#430, this CL updates the name and message of the DOMException returned when unwrapping of large IndexedDB values fails due to the data files being missing from the disk. The intention is to convey the cause and unrecoverability of the error clearly to developers so that they can add appropriate error handling. Change-Id: Ieefc4a8b2e9d6bfe9823bcb88394e438db322162 Bug: 362123231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5971136 Reviewed-by: Evan Stade <[email protected]> Commit-Queue: Abhishek Shanthkumar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1377584}
This PR:
UnknownErrorto convey that it should be used for transient reasons, per the Web IDL Standard.NotReadableErrorfrom the Web IDL Standard to the list of possible exceptions.NotReadableErrorto be returned when reading the value from the underlying storage fails in theobject-store-retrieval-operationalgorithms.Closes #423
The following tasks have been completed:
Modified Web platform tests (link to pull request)A WPT for this scenario does not seem feasible because the location of IndexedDB data on disk differs across browsers and platforms.Implementation commitment:
Preview | Diff