Mark DOMException as serializable #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also define serialization and deserialization steps. tests: web-platform-tests/wpt#17095 Fixes #729.
|
PTAL |
domenic
approved these changes
May 30, 2019
There was a problem hiding this comment.
LGTM with nit. I guess we should wait for multi-implementer interest over in whatwg/html#4268. (/cc @jorendorff)
|
Note the problem described in whatwg/html#4268 (comment) |
Co-Authored-By: Domenic Denicola <[email protected]>
domenic
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 4, 2019
Supplements #17095. Follows whatwg/html#4665 and whatwg/webidl#732.
CYBAI
reviewed
Jun 5, 2019
|
Added sentences for |
TimothyGu
reviewed
Jun 7, 2019
TimothyGu
approved these changes
Jun 10, 2019
domenic
pushed a commit
to whatwg/html
that referenced
this pull request
Jul 3, 2019
Define serialization and deserialization steps for all built-in NativeError types from the JavaScript specification. This change doesn't cover DOMExceptions, which are covered by whatwg/webidl#732. Fixes #4268. Tests: * web-platform-tests/wpt#17095 * web-platform-tests/wpt#17159
annevk
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 9, 2019
Supplements #17095. Follows whatwg/html#4665 and whatwg/webidl#732.
domenic
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 9, 2019
Supplements #17095. Follows whatwg/html#4665 and whatwg/webidl#732.
foolip
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 10, 2019
This is tests for spec changes. - whatwg/html#4665 - whatwg/webidl#732
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jul 18, 2019
Make DOMException serializable. We don't support the stack property due to some technical difficulties. Spec: whatwg/webidl#732 Intent-to-Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/f8JngIi8qYs Bug: 970079 Change-Id: I909bb5f32a79baac19108bc18eaf91eb597a8c85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697462 Commit-Queue: Yutaka Hirano <[email protected]> Reviewed-by: Jeremy Roman <[email protected]> Reviewed-by: Yuki Shiino <[email protected]> Cr-Commit-Position: refs/heads/master@{#678689}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 24, 2019
…tacks, a=testonly Automatic update from web-platform-tests Add optional test for cloning of error stacks Supplements web-platform-tests/wpt#17095. Follows whatwg/html#4665 and whatwg/webidl#732. -- wpt-commits: 1da6bed5d8c4c38200383b86928b7be68bfb87da wpt-pr: 17159 --HG-- rename : testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/resources/echo-iframe.html => testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/resources/echo-iframe.html rename : testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/resources/echo-worker.js => testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/resources/echo-worker.js
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 24, 2019
…=testonly Automatic update from web-platform-tests Add structured clone tests for errors This is tests for spec changes. - whatwg/html#4665 - whatwg/webidl#732 -- Add tests for cloning from another realm -- Test some stuff before cloning -- wpt-commits: 1b4fbe0c7049d89fd805dc157f68d82616f5d203, efc79eef01ffa65273ff01736d989ff5fa79f18d, 84af6c875d378944b39d895acdcfc170736b2d3d wpt-pr: 17095
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Jul 25, 2019
…tacks, a=testonly Automatic update from web-platform-tests Add optional test for cloning of error stacks Supplements web-platform-tests/wpt#17095. Follows whatwg/html#4665 and whatwg/webidl#732. -- wpt-commits: 1da6bed5d8c4c38200383b86928b7be68bfb87da wpt-pr: 17159
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Jul 25, 2019
…=testonly Automatic update from web-platform-tests Add structured clone tests for errors This is tests for spec changes. - whatwg/html#4665 - whatwg/webidl#732 -- Add tests for cloning from another realm -- Test some stuff before cloning -- wpt-commits: 1b4fbe0c7049d89fd805dc157f68d82616f5d203, efc79eef01ffa65273ff01736d989ff5fa79f18d, 84af6c875d378944b39d895acdcfc170736b2d3d wpt-pr: 17095
natechapin
pushed a commit
to natechapin/wpt
that referenced
this pull request
Aug 23, 2019
Supplements web-platform-tests#17095. Follows whatwg/html#4665 and whatwg/webidl#732.
natechapin
pushed a commit
to natechapin/wpt
that referenced
this pull request
Aug 23, 2019
This is tests for spec changes. - whatwg/html#4665 - whatwg/webidl#732
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
…tacks, a=testonly Automatic update from web-platform-tests Add optional test for cloning of error stacks Supplements web-platform-tests/wpt#17095. Follows whatwg/html#4665 and whatwg/webidl#732. -- wpt-commits: 1da6bed5d8c4c38200383b86928b7be68bfb87da wpt-pr: 17159 UltraBlame original commit: d0647ab7df5d71c33b5c35b8b4ce69940975639e
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
…=testonly Automatic update from web-platform-tests Add structured clone tests for errors This is tests for spec changes. - whatwg/html#4665 - whatwg/webidl#732 -- Add tests for cloning from another realm -- Test some stuff before cloning -- wpt-commits: 1b4fbe0c7049d89fd805dc157f68d82616f5d203, efc79eef01ffa65273ff01736d989ff5fa79f18d, 84af6c875d378944b39d895acdcfc170736b2d3d wpt-pr: 17095 UltraBlame original commit: 696cf52f476f2f644137d19d9b9c4ec4dc400731
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
…tacks, a=testonly Automatic update from web-platform-tests Add optional test for cloning of error stacks Supplements web-platform-tests/wpt#17095. Follows whatwg/html#4665 and whatwg/webidl#732. -- wpt-commits: 1da6bed5d8c4c38200383b86928b7be68bfb87da wpt-pr: 17159 UltraBlame original commit: d0647ab7df5d71c33b5c35b8b4ce69940975639e
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
…=testonly Automatic update from web-platform-tests Add structured clone tests for errors This is tests for spec changes. - whatwg/html#4665 - whatwg/webidl#732 -- Add tests for cloning from another realm -- Test some stuff before cloning -- wpt-commits: 1b4fbe0c7049d89fd805dc157f68d82616f5d203, efc79eef01ffa65273ff01736d989ff5fa79f18d, 84af6c875d378944b39d895acdcfc170736b2d3d wpt-pr: 17095 UltraBlame original commit: 696cf52f476f2f644137d19d9b9c4ec4dc400731
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…tacks, a=testonly Automatic update from web-platform-tests Add optional test for cloning of error stacks Supplements web-platform-tests/wpt#17095. Follows whatwg/html#4665 and whatwg/webidl#732. -- wpt-commits: 1da6bed5d8c4c38200383b86928b7be68bfb87da wpt-pr: 17159 UltraBlame original commit: d0647ab7df5d71c33b5c35b8b4ce69940975639e
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…=testonly Automatic update from web-platform-tests Add structured clone tests for errors This is tests for spec changes. - whatwg/html#4665 - whatwg/webidl#732 -- Add tests for cloning from another realm -- Test some stuff before cloning -- wpt-commits: 1b4fbe0c7049d89fd805dc157f68d82616f5d203, efc79eef01ffa65273ff01736d989ff5fa79f18d, 84af6c875d378944b39d895acdcfc170736b2d3d wpt-pr: 17095 UltraBlame original commit: 696cf52f476f2f644137d19d9b9c4ec4dc400731
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark DOMException as serialiable
Also define serialization and deserialization steps.
tests: web-platform-tests/wpt#17095
Fixes #729
Preview | Diff