Add data point for IndexedDB improved error reporting for large value read failures #25277

chrisdavidmills · 2024-12-01T09:56:52Z

Summary

Chrome has updated its error reporting for large value read failures with transient causes such as low memory and unrecoverable causes such as source blob files being deleted.

Chrome 130 updates the DOMException types to be more appropriate, and Chrome 132 further updates them and improves the associated error messages.

See https://chromestatus.com/feature/5140210640486400 for the data source.

Test results and supporting details

Related issues

…ures

caugner · 2024-12-04T18:54:05Z

api/IDBRequest.json

+          "improved_reporting_large_value_read_failures": {
+            "__compat": {
+              "description": "Improved reporting for large value read failures",


Can you point me to the part of the spec that mentions this, and/or the spec PR that added this behavior to the spec?

@caugner I'm pretty sure this is the one: w3c/IndexedDB#430.

The exceptions are listed in the spec at https://www.w3.org/TR/IndexedDB/#exceptions.

Based on w3c/IndexedDB#423, I would suggest to rename the feature as follows:

Suggested change

"improved_reporting_large_value_read_failures": {

"__compat": {

"description": "Improved reporting for large value read failures",

"throws_NotReadableError": {

"__compat": {

"description": "Throws `NotReadableError` on storage read failures",

My impression is that "large value" is Chrome terminology, not part of the spec.

/cc @Elchi3 for a second opinion, as we may see more of these very specific behavioral features in the future.

PS: We could add this spec_url: https://www.w3.org/TR/IndexedDB/#:~:text=NotReadableError

I like @caugner's description and ID a lot more but I also find it strange to use both, sub features and array support statements here. Is this the summary?

"chrome": [ { "version_added": "132", "notes": "Throws `NotReadableError` and `UnknownError`" }, { "version_added": "130", "notes": "Throws `NotFoundError` and `DataError`" }, { "version_added": "48", "notes": "Throws `DOMExceptions`" }, { "version_added": "23", "notes": "Throws `DOMError`" } ],

From reading the content discussion, I think "Transient and unrecoverable read errors" (transient_unrecoverable_read_errors) is a good feature name and id.

"Improved reporting for read errors" and then only setting Chrome to support and other browsers to false seems wrong given this is about Chrome catching up and not providing "improvements" here, right? If the other browser support it, then we should say so.

I've updated the feature name as suggested.

I agree it would be nice to include other browser support information, but I've got no idea how to find that out. I can't find a mention of NotReadableError in the Gecko source code so, although they do support the same kind of error handling for read errors, I'm not sure if it is using the same exception names.

From the spec bug, I am wondering whether this has bene agreed as the error to put in the spec, which matches Fx behavior, but Fx hasn't actually implemented the official specified error yet. In which case, could we call it something like "Specified reporting for read errors", and it would be accurate to say that only Chrome has implemented it so far?

I'm not 100% sure, but most likely it was Firefox 14 that implemented NotReadableError in https://bugzilla.mozilla.org/show_bug.cgi?id=730161, cf. mozilla/gecko-dev@1ce6cdf#diff-38a23a8920ed3a6e05068b536b2ba2f20b2ef6449a7a084ee0bc76faeca8e6d5R45

Webkit most likely implemented it in https://bugs.webkit.org/show_bug.cgi?id=102137 / WebKit/WebKit@b368491, i.e. Safari 537.43.1 before Safari 7 (537.71).

That sounds good enough for me ;-)

caugner · 2024-12-10T16:21:00Z

api/IDBRequest.json

+          "improved_reporting_large_value_read_failures": {
+            "__compat": {
+              "description": "Improved reporting for large value read failures",


Based on w3c/IndexedDB#423, I would suggest to rename the feature as follows:

Suggested change

"improved_reporting_large_value_read_failures": {

"__compat": {

"description": "Improved reporting for large value read failures",

"throws_NotReadableError": {

"__compat": {

"description": "Throws `NotReadableError` on storage read failures",

My impression is that "large value" is Chrome terminology, not part of the spec.

/cc @Elchi3 for a second opinion, as we may see more of these very specific behavioral features in the future.

caugner · 2024-12-10T16:29:16Z

api/IDBRequest.json

+                  {
+                    "version_added": "130",
+                    "partial_implementation": true,
+                    "notes": "Throws a `NotFoundError` for unrecoverable large value read failures, and a `DataError` for transient large value read failures."


Note that the NotFoundError has been in the spec since at least 2011 (before it was referred to as NOT_FOUND_ERR).

That's true. It is only mentioned here because Chrome reported that error type for read errors for a couple of versions (incorrectly, I assume), before it was then updated to NotReadableError.

api/IDBRequest.json

Co-authored-by: Claas Augner <[email protected]>

Co-authored-by: Florian Scholz <[email protected]>

…ue-read-failures

…lures' of github.com:chrisdavidmills/browser-compat-data into indexeddb-improved-error-reporting-large-value-read-failures

chrisdavidmills · 2024-12-13T14:25:34Z

@caugner @Elchi3 I had to make some further updates due to linting failures. I noticed that the new data point had been put at the wrong nesting level (oops!), and I had to adjust the support versions for FxA and Saf because the specified values were earlier than the support values for the parent feature.

caugner

Looks good and plausible to me.

Add data point for improved error reporting for large value read fail…

000273f

…ures

github-actions bot added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API size:m [PR only] 25-100 LoC changed labels Dec 1, 2024

chrisdavidmills changed the title ~~Add data point for improved error reporting for large value read fail…~~ Add data point for IndexedDB improved error reporting for large value read fail… Dec 1, 2024

caugner reviewed Dec 4, 2024

View reviewed changes

caugner requested changes Dec 10, 2024

View reviewed changes

caugner reviewed Dec 10, 2024

View reviewed changes

chrisdavidmills added 2 commits December 11, 2024 12:38

Make sure some updates based on review comments

656605e

Make some updates based on review comments

90311d3

chrisdavidmills requested review from caugner and Elchi3 December 11, 2024 13:00

Update feature name to the suggestion in the code review

7e1ca94

caugner requested changes Dec 13, 2024

View reviewed changes

api/IDBRequest.json Outdated Show resolved Hide resolved

api/IDBRequest.json Outdated Show resolved Hide resolved

api/IDBRequest.json Outdated Show resolved Hide resolved

Elchi3 reviewed Dec 13, 2024

View reviewed changes

api/IDBRequest.json Outdated Show resolved Hide resolved

chrisdavidmills and others added 7 commits December 13, 2024 14:07

Update api/IDBRequest.json

f790e32

Co-authored-by: Claas Augner <[email protected]>

Update api/IDBRequest.json

3c16336

Co-authored-by: Claas Augner <[email protected]>

Update api/IDBRequest.json

e8d8bb9

Co-authored-by: Claas Augner <[email protected]>

Update api/IDBRequest.json

b8f86c9

Co-authored-by: Florian Scholz <[email protected]>

correct nesting level and support versions

aeade4b

Merge branch 'main' into indexeddb-improved-error-reporting-large-val…

c785b05

…ue-read-failures

Merge branch 'indexeddb-improved-error-reporting-large-value-read-fai…

5c7e0ed

…lures' of github.com:chrisdavidmills/browser-compat-data into indexeddb-improved-error-reporting-large-value-read-failures

chrisdavidmills requested review from Elchi3 and caugner December 13, 2024 14:25

queengooborg changed the title ~~Add data point for IndexedDB improved error reporting for large value read fail…~~ Add data point for IndexedDB improved error reporting for large value read failures Dec 17, 2024

caugner approved these changes Dec 20, 2024

View reviewed changes

caugner merged commit d474df5 into mdn:main Dec 20, 2024
9 checks passed

mdn-bot mentioned this pull request Dec 20, 2024

Release v5.6.26 #25454

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add data point for IndexedDB improved error reporting for large value read failures #25277

Add data point for IndexedDB improved error reporting for large value read failures #25277

chrisdavidmills commented Dec 1, 2024 •

edited by queengooborg

Loading

caugner Dec 4, 2024

chrisdavidmills Dec 9, 2024

caugner Dec 10, 2024

caugner Dec 10, 2024

Elchi3 Dec 11, 2024

Elchi3 Dec 12, 2024

chrisdavidmills Dec 12, 2024

caugner Dec 13, 2024

caugner Dec 13, 2024

chrisdavidmills Dec 13, 2024

caugner Dec 10, 2024

caugner Dec 10, 2024

chrisdavidmills Dec 11, 2024

chrisdavidmills commented Dec 13, 2024

caugner left a comment

Add data point for IndexedDB improved error reporting for large value read failures #25277

Add data point for IndexedDB improved error reporting for large value read failures #25277

Conversation

chrisdavidmills commented Dec 1, 2024 • edited by queengooborg Loading

Summary

Test results and supporting details

Related issues

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chrisdavidmills commented Dec 13, 2024

caugner left a comment

Choose a reason for hiding this comment

chrisdavidmills commented Dec 1, 2024 •

edited by queengooborg

Loading