Skybox improvements (E346-E347) #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neede for getting rid of some skybox 𝘱𝘦𝘯𝘦𝘵𝘳𝘢𝘵𝘪𝘰𝘯 glitches, see #579
Also: - add more info to texture upload debug logs - remove obsoleted code - prepare for engine/imagelib-side cubemaps
Engine imagelib already has skybox loader. It uses rgbdata_t IMAGE_CUBEMAP flag. 1. Support IMAGE_CUBEMAP 2. Utilize imagelib skybox loader, do not try to load individual skybox sides manually. This will allow loading KTX2 cubemaps directly. Known issues: 1. Compressed KTX2 sides are not rotated correctly. Engine/imagelib is unable to rotate compressed images. 2. Some KTX2 sides are corrupted. Cause unknown.
For some very unknown reason there's a line that fixes image size to w*h*4, which would correspond to RGBA8 pixel format w/o alignment. This is extremely incorrect for other pixel format, e.g. compressed ones. Not sure why this size-fixing was there, but removing it fixes sided KTX2 compressed skybox corruption.
|
Прикладываю тестовую кубемапу с текстом для проверки ориентации: cubemap_test.zip |
E.g. add `desert.mat` alongside `desert.ktx2` (or
`desrt_{rt,lf,...}.png` files) with the following contents:
```
exposure 0.3
```
Skybox texture color will be multiplied by this value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SURF_DRAWSKYsurfaces.SURF_DRAWSKYsurfaces via"_xvk_remove_all_sky_surfaces" "1", Draw a skybox if the ray hit on nothing #579