Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize skybox loading #706

Closed
Tracked by #708
w23 opened this issue Dec 11, 2023 · 1 comment
Closed
Tracked by #708

Optimize skybox loading #706

w23 opened this issue Dec 11, 2023 · 1 comment
Labels
patching Related to pathing vanilla game data performance Performance improvement needed ray tracing regression What worked but was broken

Comments

@w23
Copy link
Owner

w23 commented Dec 11, 2023 •
edited
Loading

With the new hi-res skyboxes it became extremely slow. Feels like roughly more than half of map loading time.

What could we do:

  • determine whether the map even has SURF_SKY. If it doesn't then skybox can be completely omitted.
  • support loading packed KTX2 cubemaps directly
  • cache: do not unload then reload the same skybox
@w23 w23 added ray tracing performance Performance improvement needed regression What worked but was broken patching Related to pathing vanilla game data labels Dec 11, 2023
@w23 w23 added this to HLRT Dec 11, 2023
@0x4E69676874466F78
Copy link
Collaborator

0x4E69676874466F78 commented Dec 11, 2023 •
edited
Loading

determine whether the map even has SURF_SKY. If it doesn't then skybox can be completely omitted.

Это надо делать заодно с #579

support loading packed KTX2 cubemaps directly

А это #677 пункт про glTF-IBL-Sampler

@0x4E69676874466F78 0x4E69676874466F78 moved this to 🆕 New in HLRT Dec 11, 2023
@w23 w23 moved this from 🆕 New to 🏗 In progress in HLRT Dec 12, 2023
w23 added a commit that referenced this issue Dec 14, 2023
@w23
vk: rt: optimize hires skybox loading
3cbc11a 
- Do not load skybox at all if there are no SURF_DRAWSKY, #706, #579
- Do not reload the same skybox, #706

Also refactor skybox loading a bit. Prepare for KTX2 skyboxes.
@w23 w23 mentioned this issue Dec 18, 2023
Merged
9 tasks
w23 added a commit that referenced this issue Dec 18, 2023
@w23
Merge pull request #708 from w23/stream-E346
7e0553d 
Skybox improvements (E346-E349)

- [x] #706 
  - [x] Do not load skybox if map doesn't have any `SURF_DRAWSKY` surfaces.
  - [x] Cache: do not reload the same skybox.
  - [x] Enable loading packed KTX2 cubemaps as skyboxes in engine/imagelib
- [x] Reuse existing imagelib cubemap loading routines, remove custom skybox loading code
- [x] Allow hiding `SURF_DRAWSKY` surfaces via `"_xvk_remove_all_sky_surfaces" "1"`, #579 
- [x] #677 
  - [x] Add skybox exposure control for HDR skyboxes
  - [x] Allow reloading skyboxes when reloading patches
@w23 w23 closed this as completed Dec 18, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in HLRT Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
patching Related to pathing vanilla game data performance Performance improvement needed ray tracing regression What worked but was broken
Projects
HLRT
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@w23 @0x4E69676874466F78