-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proper italic/cursive rendering #759
Comments
Hi! This is a part of the CommonMark Spec. We cannot change the standards.
|
We don't have an italic font face. 😅 In Chrome it works because it falls back to other fonts. |
Using Chromium on Fedora, italics don't seem to work for me. |
Thanks for the quick answer @brc-dd! I know that Given that the problem lays in the font used, I guess the default font should be changed to support italics by default? I don't believe that people should manually change the font to one with italics support if they want italics. Also, I would add a CSS to ensure that the |
* refactor: refine global layout system * chore: remove unknown console log from release script * release: v1.0.0-alpha.2 * docs: add Layer0 deployment notes Co-authored-by: meteorlxy <[email protected]> * docs: add cloudflare pages deploy (#797) close #369 Co-authored-by: Kia King Ishii <[email protected]> * refactor: improve site data parsing (#780) * fix: copy code in non-secure contexts (#792) Co-authored-by: Divyansh Singh <[email protected]> * fix(theme): add italic fonts (#759) (#777) fix #759 * docs: image migration guide for vuepress (#799) * refactor(types): use built-in utility type `Awaited` (#801) instead of explicitly defining it. (introduced in TS 4.5) * feat(theme): support themeable images for logo and hero (#745) Co-authored-by: Divyansh Singh <[email protected]> Co-authored-by: Kia King Ishii <[email protected]> Co-authored-by: Rishi Raj Jain <[email protected]> Co-authored-by: meteorlxy <[email protected]> Co-authored-by: Percy Ma <[email protected]> Co-authored-by: Linmj <[email protected]> Co-authored-by: JD Solanki <[email protected]> Co-authored-by: CHOYSEN <[email protected]> Co-authored-by: Anthony Fu <[email protected]>
Describe the bug
As of now, if you format text as italic/cursive (with either
_
or*
) it gets transpiled to HTML as an<em>
element, instead of<i>
. This works in chromium-based browser (as far as I've seen), but for example doesn't show as italic in the latest Firefox versions.Reproduction
In a Markdown file, wrap any text in a single
_
or*
(make it cursive), compile and search that text in the page with Firefox.Expected behavior
Render it to an
<i>
tag so it is properly formatted in both Chromium-based and Gecko-based (Firefox & others). Alternatively, a CSS could be included by default that formats<em>
as italic/cursive.System Info
Additional context
No response
Validations
The text was updated successfully, but these errors were encountered: