Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Italic font rendering doesn't work in Safari #1558

Closed
3 tasks done
LittleChimera opened this issue Oct 30, 2022 · 5 comments · Fixed by #1710
Closed
3 tasks done

Italic font rendering doesn't work in Safari #1558

LittleChimera opened this issue Oct 30, 2022 · 5 comments · Fixed by #1710
Assignees
Labels
bug Something isn't working theme Related to the theme

Comments

@LittleChimera
Copy link
Contributor

Describe the bug

Instead of italic font rendering, only regular font is displayed in Safari.

Reproduction

Write a markdown with italic rendering, and open in Safari.

Expected behavior

Expected to render italic font.

System Info

not important

Additional context

Relevant issue: #759

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
@LittleChimera LittleChimera added the bug: pending triage Maybe a bug, waiting for confirmation label Oct 30, 2022
@brc-dd
Copy link
Member

brc-dd commented Oct 30, 2022

Which version of VitePress and Safari are you using? It's working fine for me on Safari 15.6.

@brc-dd brc-dd added need more info Further information is requested and removed bug: pending triage Maybe a bug, waiting for confirmation labels Oct 30, 2022
@brc-dd
Copy link
Member

brc-dd commented Nov 13, 2022

Closing as stale.

@brc-dd brc-dd closed this as not planned Won't fix, can't repro, duplicate, stale Nov 13, 2022
@infotexture
Copy link

infotexture commented Dec 17, 2022

@brc-dd This is still a problem in Safari 16.2 with 1.0.0-alpha.32.

Looks like italic fonts were missing when you wrote #759 (comment).

With the switch to 'Inter var experimental', 'Inter var' for #759 with #777, it seems like it should work, but still doesn't, even with a custom CSS rule to force <em> to italic:

em {
  font-style: italic;
}

Works fine in Chrome & Firefox.

@infotexture
Copy link

@rsms ❓ Should this work — or do we need other CSS tricks to get Safari to render italics with Inter’s variable variant? 🤔

@brc-dd brc-dd reopened this Dec 17, 2022
@brc-dd brc-dd added bug Something isn't working theme Related to the theme and removed need more info Further information is requested labels Dec 17, 2022
@brc-dd brc-dd self-assigned this Dec 17, 2022
@rsms
Copy link

rsms commented Dec 17, 2022

Make sure to use the official releases from rsms.me/inter (or GitHub.com/rsms/inter/releases.)
Google Fonts’ version of Inter does not include italics (and is pretty old.)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working theme Related to the theme
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants