Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: EmptyState Tweaks token name. #125

Merged
merged 5 commits into from
Jun 15, 2022

Conversation

eduardoformiga
Copy link
Member

@eduardoformiga eduardoformiga commented Jun 15, 2022

What's the purpose of this pull request?

Implements these sugestions.

Checklist

You may erase this after checking them all ;)

Changelog

  • Added an entry in the CHANGELOG.md at the beginning of its due section. The latest version should comes first.
  • Added the PR number with the PR link at the entry in the CHANGELOG.md. E.g., New items in the pull_request_template.md (#4)

PR Description

  • Added a label according to the PR goal - Breaking change, Enhancement, Bug or Chore.
  • Added the component, hook, or pathname in-between backticks (``) - If applicable. E.g., ComponentName component.
  • Identified the function or parameter in the PR - If applicable. E.g., useWindowDimensions hook.

Documentation

  • PR description
  • Added to/Updated the Storybook - if applicable.
  • For documentation changes, ping @ carolinamenezes, @ PedroAntunesCosta or @ Mariana-Caetano to review and update.

@vercel
Copy link

vercel bot commented Jun 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nextjs-store-storybook ✅ Ready (Inspect) Visit Preview Jun 15, 2022 at 5:31PM (UTC)

@vtex-sites
Copy link

vtex-sites bot commented Jun 15, 2022

Preview is ready

This pull request generated a Preview

👀   Preview: https://sfj-c829bbe--nextjs.preview.vtex.app
🔬   Go deeper by inspecting the Build Logs
📝   based on commit c829bbe

@eduardoformiga eduardoformiga self-assigned this Jun 15, 2022
@eduardoformiga eduardoformiga added the Chore General tasks. label Jun 15, 2022
@eduardoformiga eduardoformiga marked this pull request as ready for review June 15, 2022 17:15
@eduardoformiga eduardoformiga requested review from renatamottam and a team June 15, 2022 17:16
@vercel vercel bot temporarily deployed to preview June 15, 2022 17:16 Inactive
Copy link
Contributor

@filipewl filipewl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First signs of this getting out of sync.
😬

src/components/cart/EmptyCart/EmptyCart.stories.mdx Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to preview June 15, 2022 17:23 Inactive
@eduardoformiga
Copy link
Member Author

First signs of this getting out of sync. 😬

Well noticed!

I'll replicate it on Gatsby starter as well.

@vercel vercel bot temporarily deployed to preview June 15, 2022 17:31 Inactive
@vtex-sites
Copy link

vtex-sites bot commented Jun 15, 2022

Lighthouse Reports

Here are the Lighthouse reports of this Pull Request

📝 Based on commit c829bbe

Lighthouse Report by page
📎   /
📎   /apple-magic-mouse/p
📎   /office

@eduardoformiga eduardoformiga merged commit c829bbe into main Jun 15, 2022
@eduardoformiga eduardoformiga deleted the chore/theming-empty-state-fsss-374 branch June 15, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore General tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants