Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: EmptyState Tweaks token name. #125

Merged
merged 5 commits into from
Jun 15, 2022
Merged

Chore: EmptyState Tweaks token name. #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f9be874
Tweaks token name and space
eduardoformiga Jun 15, 2022
c69158d
Adds CHANGELOG entry
eduardoformiga Jun 15, 2022
989d88b
Update src/components/cart/EmptyCart/EmptyCart.stories.mdx
eduardoformiga Jun 15, 2022
7c6e59b
Update src/components/sections/ProductGallery/EmptyGallery.stories.mdx
eduardoformiga Jun 15, 2022
65cb2fc
Trigger CI
eduardoformiga Jun 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Tweaks `EmptyState` token name ([#125](https://github.com/vtex-sites/nextjs.store/pull/125))
- Storybook's version from 6.4.20 to 6.5.9 ([#120](https://github.com/vtex-sites/nextjs.store/pull/120))
- Unifies `Link` component usage by adding support for both external and client-side links ([#117](https://github.com/vtex-sites/nextjs.store/pull/117))

Expand Down
5 changes: 1 addition & 4 deletions src/components/cart/EmptyCart/EmptyCart.stories.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,5 @@ An implementation of the `EmptyState` that represents the Cart with no items.
value="var(--fs-color-disabled-text)"
isColor
/>
<TokenRow
token="--fs-empty-state-title-text-size"
value="var(--fs-text-size-3)"
/>
<TokenRow token="--fs-empty-state-title-size" value="var(--fs-text-size-lead)" />
</TokenTable>
5 changes: 1 addition & 4 deletions src/components/sections/ProductGallery/EmptyGallery.stories.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,7 @@ An implementation of the `EmptyState` that represents a Gallery with no items.
value="var(--fs-color-disabled-text)"
isColor
/>
<TokenRow
token="--fs-empty-state-title-text-size"
value="var(--fs-text-size-3)"
/>
<TokenRow token="--fs-empty-state-title-size" value="var(--fs-text-size-lead)" />
</TokenTable>

### Link
Expand Down
8 changes: 4 additions & 4 deletions src/components/ui/EmptyState/empty-state.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@
--fs-empty-state-bkg-color : var(--fs-color-neutral-bkg);

// Title
--fs-empty-state-title-margin-bottom : var(--fs-spacing-2);
--fs-empty-state-title-color : var(--fs-color-disabled-text);
--fs-empty-state-title-text-size : var(--fs-text-size-lead);
--fs-empty-state-title-margin-bottom : var(--fs-spacing-2);
--fs-empty-state-title-color : var(--fs-color-disabled-text);
--fs-empty-state-title-size : var(--fs-text-size-lead);

// Link
--fs-empty-state-link-min-width : 11.875rem;
Expand Down Expand Up @@ -44,7 +44,7 @@
color: var(--fs-empty-state-title-color);

p {
font-size: var(--fs-empty-state-title-text-size);
font-size: var(--fs-empty-state-title-size);
text-align: center;
}
}
Expand Down