-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Adds tokens to EmptyState
#122
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Preview is readyThis pull request generated a Preview👀 Preview: https://sfj-7405d17--nextjs.preview.vtex.app |
Lighthouse ReportsHere are the Lighthouse reports of this Pull Request📝 Based on commit 7405d17
|
Co-authored-by: Fanny Chien <[email protected]>
Co-authored-by: Fanny Chien <[email protected]>
Co-authored-by: Fanny Chien <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice!
Co-authored-by: Fanny Chien <[email protected]>
…m/vtex-sites/nextjs.store into feat/theming-empty-state-fsss-374
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done forms!!! 🤩 LGTM!
Co-authored-by: Fanny Chien <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some suggestions for the doc organization, we can talk later :)
I implemented it here. Thanks! |
What's the purpose of this pull request?
This PR applies the new Theming structure to
EmptyState
: new scoped tokens linked to global ones.How does it work?
This PR uses local variables to parameterize the
EmptyState
properties, then connects these scoped tokens to the global ones.New local tokens for
EmptyState
--fs-empty-state-height
100%
--fs-empty-state-min-height
50vh
--fs-empty-state-padding
0 var(--fs-spacing-8)
--fs-empty-state-bkg-color
var(--fs-color-neutral-bkg)
Rounded Variant
--fs-empty-state-border-radius
var(--fs-border-radius)
Related Components
Nested Elements
Title
--fs-empty-state-title-margin-bottom
var(--fs-spacing-2)
--fs-empty-state-title-color
var(--fs-color-disabled-text)
--fs-empty-state-title-size
var(--fs-text-size-3)
Link
--fs-empty-state-link-min-width
11.875rem
How to test it?
EmptyState
component and its related components should look just as it was before these changes.Checklist
You may erase this after checking them all ;)
Changelog
CHANGELOG.md
at the beginning of its due section. The latest version should comes first.CHANGELOG.md
. E.g., New items in thepull_request_template.md
(#4)PR Description
Breaking change
,Enhancement
,Bug
orChore
.ComponentName
component.useWindowDimensions
hook.Documentation