Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: EmptyState Use Cases section #126

Merged
merged 5 commits into from
Jun 16, 2022
Merged

Chore: EmptyState Use Cases section #126

merged 5 commits into from
Jun 16, 2022

Conversation

eduardoformiga
Copy link
Member

@eduardoformiga eduardoformiga commented Jun 15, 2022 •
edited
Loading

What's the purpose of this pull request?

follow up #122

Aims to show the Use Cases section on the storybook instead of related components and its own files.

How to test it?

check the storybook

Checklist

You may erase this after checking them all ;)

Changelog

  • Added an entry in the CHANGELOG.md at the beginning of its due section. The latest version should comes first.
  • Added the PR number with the PR link at the entry in the CHANGELOG.md. E.g., New items in the pull_request_template.md (#4)

PR Description

  • Added a label according to the PR goal - Breaking change, Enhancement, Bug or Chore.
  • Added the component, hook, or pathname in-between backticks (``) - If applicable. E.g., ComponentName component.
  • Identified the function or parameter in the PR - If applicable. E.g., useWindowDimensions hook.

Documentation

  • PR description
  • Added to/Updated the Storybook - if applicable.
  • For documentation changes, ping @ carolinamenezes, @ PedroAntunesCosta or @ Mariana-Caetano to review and update.

@vercel
Copy link

vercel bot commented Jun 15, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nextjs-store-storybook ✅ Ready (Inspect) Visit Preview Jun 15, 2022 at 11:14PM (UTC)

@vtex-sites
Copy link

vtex-sites bot commented Jun 15, 2022 •
edited
Loading

Preview is ready

This pull request generated a Preview

👀   Preview: https://sfj-22ddd87--nextjs.preview.vtex.app
🔬   Go deeper by inspecting the Build Logs
📝   based on commit 22ddd87

@eduardoformiga eduardoformiga added Chore General tasks. Features New feature or request labels Jun 15, 2022
@eduardoformiga eduardoformiga requested review from renatamottam and a team June 15, 2022 22:29
@eduardoformiga eduardoformiga marked this pull request as ready for review June 15, 2022 22:30
@vercel vercel bot temporarily deployed to preview June 15, 2022 22:30 Inactive
@vercel vercel bot temporarily deployed to preview June 15, 2022 22:37 Inactive
@vercel vercel bot temporarily deployed to preview June 15, 2022 22:42 Inactive
@vercel vercel bot temporarily deployed to preview June 15, 2022 22:46 Inactive
@eduardoformiga eduardoformiga force-pushed the chore/empty-state-storybook branch from 220a6d6 to b776d57 Compare June 15, 2022 22:53
@vercel vercel bot temporarily deployed to preview June 15, 2022 22:58 Inactive
@vercel vercel bot temporarily deployed to preview June 15, 2022 23:08 Inactive
@vercel vercel bot temporarily deployed to preview June 15, 2022 23:14 Inactive
@vtex-sites
Copy link

vtex-sites bot commented Jun 15, 2022

Lighthouse Reports

Here are the Lighthouse reports of this Pull Request

📝 Based on commit d3f3f47

Lighthouse Report by page
📎   /
📎   /apple-magic-mouse/p
📎   /office

hellofanny
hellofanny approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@hellofanny hellofanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice changes ~

renatamottam
renatamottam approved these changes Jun 16, 2022
View reviewed changes
Copy link
Collaborator

@renatamottam renatamottam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@eduardoformiga eduardoformiga merged commit 22ddd87 into main Jun 16, 2022
@eduardoformiga eduardoformiga deleted the chore/empty-state-storybook branch June 16, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatamottam renatamottam renatamottam approved these changes

@hellofanny hellofanny hellofanny approved these changes

Assignees
No one assigned
Labels
Chore General tasks. Features New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eduardoformiga @hellofanny @renatamottam