[Hotfix] Alert and InlineAlert refs #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LJKaski
requested review from
riitasointi,
Riippi and
jenkrisu
as code owners
LJKaski
force-pushed
the
hotfix/alert-component-refs
branch
from
ba0e6bd to
8c4dea0
Compare
riitasointi
approved these changes
Oct 24, 2023
LJKaski
added a commit
that referenced
this pull request
Oct 25, 2023
[Hotfix] Alert and InlineAlert refs
LJKaski
added a commit
that referenced
this pull request
Oct 25, 2023
[Hotfix] Alert and InlineAlert refs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Alert and InlineAlert
forwardedRefprops weren't correctly implemented and would in some cases show in the DOM and cause warnings. This PR fixes the issue.Motivation and Context
These were issues reported by developers using the library.
How Has This Been Tested?
By checking ref functionality in styleguidist on Chrome.
Release notes
Alert, InlineAlert