Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] Alert and InlineAlert refs #790

Merged
merged 3 commits into from
Oct 25, 2023
Merged

[Hotfix] Alert and InlineAlert refs #790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5dbf4a8
correctly implement InlineAlert forwardedRef prop
LJKaski Oct 24, 2023
8c4dea0
fix ref implementation in Alert
LJKaski Oct 24, 2023
1395776
raise version number to 12.0.2
LJKaski Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "suomifi-ui-components",
"version": "12.0.1",
"version": "12.0.2",
"description": "Suomi.fi UI component library",
"main": "dist/cjs/index.js",
"module": "dist/esm/index.js",
Expand Down
2 changes: 2 additions & 0 deletions src/core/Alert/Alert.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ class BaseAlert extends Component<AlertProps> {
closeText,
onCloseButtonClick,
smallScreen,
forwardedRef,
closeButtonProps = {},
...passProps
} = this.props;
Expand All @@ -73,6 +74,7 @@ class BaseAlert extends Component<AlertProps> {
[`${baseClassName}--${status}`]: !!status,
[alertClassNames.smallScreen]: !!smallScreen,
})}
ref={forwardedRef}
>
<HtmlDiv className={alertClassNames.styleWrapper}>
{status === 'warning' && (
Expand Down
2 changes: 2 additions & 0 deletions src/core/InlineAlert/InlineAlert.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ class BaseInlineAlert extends Component<InlineAlertProps> {
children,
smallScreen,
id,
forwardedRef,
...passProps
} = this.props;

Expand All @@ -58,6 +59,7 @@ class BaseInlineAlert extends Component<InlineAlertProps> {
[`${baseClassName}--${status}`]: !!status,
[inlineAlertClassNames.smallScreen]: !!smallScreen,
})}
ref={forwardedRef}
>
<HtmlDiv className={inlineAlertClassNames.styleWrapper}>
{status === 'warning' && (
Expand Down