[Hotfix] LoadingSpinner ref #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riitasointi
requested review from
LJKaski,
Riippi and
jenkrisu
as code owners
LJKaski
approved these changes
Nov 23, 2023
riitasointi
added a commit
that referenced
this pull request
Nov 24, 2023
[Hotfix] LoadingSpinner ref
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR contains a hotfix to LoadingSpinner. Ref/forwardedRef was not correctly used inside the component and was not working at all. Similar thing was hotfixed to Alert & InlineAlert #790 previously
Also inreased version to 12.0.3 in anticipation of a hotfix release
How Has This Been Tested?
Checking ref behavior in Styleguidist
Release notes
LoadingSpinner