-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support min-max elastic quota scheduling #3702
Conversation
2723632
to
760fe57
Compare
/assign @william-wang @wangyang0616 @Monokaix @hwdef |
seems it's a little complex for users to use the capacity plugin or queue capability, and the problem in #3703 is really a common case? |
Another solution is to add a min-max plugin. But it also need modify some codes in main actions. |
|
760fe57
to
d35c435
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1. if overusedCheckGangEnable in allocate, overused check weather job's request will exceed capability or deserved according to it is preemptable or not; 2. if overusedCheckGangEnable in reclaim, Preemptive check weather job's request will exceed deserved, if true, job in that queue can not reclaim Signed-off-by: lowang-bh <[email protected]>
d35c435
to
f272ca2
Compare
Please rebase the master code |
Image this scene:queue has some guranteed quota called
Min
. Pods can be scheduled when queue's used quota + requests <= Min. And there is also a limit quota calledMax
, which means the upper quota a queue's tasks can used. While the quota between Min and Max can only be used by preemtable tasks in a queue, because those quota are borrowed from other queues' Min, and should be returned back when need. So preemtable pods can be scheduled when queue's used quota + requests <= Max.This feature also called Elastic Quota or Capacity Scheduling.
referance:
capacity-scheduling
Elastic Quota Management
This Pr will do those things base on capacity plugin:
Min
equals todeserved
andMax
equals tocapability
Min
if job's tasks are not preemptable, or queue's used will be underMax
if job's tasks are preemptable when schedule a job.Preemtive
function in capacity plugin to support check if queue's future used (a job's request + queue's allocated) is underMin
. Only a job in a queue whose futrue used will not exceed its Min can preemt other victims.relative issues: #3537
fixes #3703
The 1st commit is base on #3649, please merge that PR first.