Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource compare only consider requested dimension #3537

Closed
4 tasks
lowang-bh opened this issue Jun 22, 2024 · 3 comments · Fixed by #3696
Closed
4 tasks

resource compare only consider requested dimension #3537

lowang-bh opened this issue Jun 22, 2024 · 3 comments · Fixed by #3696
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@lowang-bh
Copy link
Member

lowang-bh commented Jun 22, 2024

What would you like to be added:

A func LessEqualWithDimension has been added in PR #3522, which can be used to compare the only required dimension resource in those functions:

  • AddOverusedFn
  • AddPreemptiveFn
  • AddJobEnqueueableFn
  • AddAllocatableFn

Why is this needed:

Conserder those scenes:

    1. Queue‘s Gpu is really overused, but used CPU and Memory are both less than deserved. So a coming job just requesting CPU/Mem should be allocated.
    1. same as 1, Queue's CPU/Memory are not used up, but cluster has no free resource, a coming job just requesting cpu/memory can reclaim(which is preemptive) from other queue.

what's more, a queue's preemptable job can use as most as queue's capacity when check queue's overused, because those resource can be reclaimed.

@lowang-bh lowang-bh added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 22, 2024
@wangyysde
Copy link
Contributor

Whether these feature is urgent? I try to modify AddOverusedFn if it is not urgent.
@lowang-bh

@wangyysde wangyysde removed their assignment Jul 4, 2024
@wangyysde
Copy link
Contributor

cc @wangyysde

@Monokaix
Copy link
Member

Whether these feature is urgent? I try to modify AddOverusedFn if it is not urgent. @lowang-bh

Yeah you can try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants