resource compare support only consider the requested resource item #3522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volcano-sh-bot
added
the
size/L
lowang-bh
force-pushed
the
issue3520
branch
2 times, most recently
from
c495d5c
to
8a78264
Compare
lowang-bh
force-pushed
the
issue3520
branch
2 times, most recently
from
2b27d71
to
1285f2e
Compare
4 tasks
Monokaix
reviewed
Jul 2, 2024
Signed-off-by: lowang-bh <[email protected]>
hwdef
reviewed
Jul 10, 2024
Monokaix
reviewed
Jul 17, 2024
| ScalarResources: map[v1.ResourceName]float64{"nvidia.com/gpu": 1}, | ||
| }, | ||
| expected: false, | ||
| }, |
There was a problem hiding this comment.
req need gpu resource with 1， and resource2 has no gpu, so it can not satisfy the request.
Monokaix
reviewed
Jul 17, 2024
Monokaix
reviewed
Jul 17, 2024
Monokaix
reviewed
Aug 1, 2024
| // LessEqualWithDimension only compare the resource items in req param | ||
| // @param req define the resource item to be compared | ||
| // if req is nil, equals r.LessEqual(rr, zero) | ||
| func (r *Resource) LessEqualWithDimension(rr *Resource, req *Resource) bool { |
There was a problem hiding this comment.
How about just remove the dimensions not in req of r, then compare just like before?
There was a problem hiding this comment.
I think this way is more readable.
|
|
Monokaix
reviewed
Aug 6, 2024
Monokaix
reviewed
Aug 6, 2024
Signed-off-by: lowang-bh <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hwdef The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
|
because lgtm has been added by @Monokaix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3520
some times, we need to only compare the required dimensions in the resource.
eg: when check
Enqueueable,AllocatableorPreemptive, even overused.Will use this function to replcae comparision in
AddJobEnqueueableFn,AddPreemptiveFnandAddAllocatableFn