Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't enable error cache if task role spec is empty #3649

Merged
merged 1 commit into from
Sep 18, 2024
Merged

don't enable error cache if task role spec is empty #3649

merged 1 commit into from
Sep 18, 2024

Conversation

lowang-bh
Copy link
Member

@lowang-bh lowang-bh commented Aug 1, 2024 •
edited
Loading

fixes #3527
fixes #3666

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 1, 2024
@Monokaix
Copy link
Member

Monokaix commented Aug 5, 2024

What's difference between this and cacheEnable in predict plugin?

@lowang-bh
Copy link
Member Author

What's difference between this and cacheEnable in predict plugin?

This err cache is used to store those failed nodes list for same role.
The one in prediction plugin is used to store succeeded nodes list

@lowang-bh lowang-bh mentioned this pull request Aug 9, 2024
Closed
@volcano-sh-bot volcano-sh-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 13, 2024
@volcano-sh-bot volcano-sh-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2024
@lowang-bh lowang-bh closed this Aug 16, 2024
@lowang-bh lowang-bh reopened this Aug 16, 2024
@lowang-bh lowang-bh closed this Aug 19, 2024
@lowang-bh lowang-bh reopened this Aug 19, 2024
@lowang-bh
Copy link
Member Author

/assign @Monokaix @hwdef

@lowang-bh lowang-bh mentioned this pull request Sep 1, 2024
Open
@Monokaix
Copy link
Member

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2024
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Monokaix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2024
@volcano-sh-bot volcano-sh-bot merged commit 0843c0d into volcano-sh:master Sep 18, 2024
14 checks passed
@lowang-bh lowang-bh deleted the fixEnableErrCache branch September 18, 2024 04:28
@lowang-bh lowang-bh mentioned this pull request Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Monokaix Monokaix Monokaix left review comments

@hwdef hwdef hwdef left review comments

@merryzhou merryzhou Awaiting requested review from merryzhou

@shinytang6 shinytang6 Awaiting requested review from shinytang6

Assignees

@hwdef hwdef

@Monokaix Monokaix

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
4 participants
@lowang-bh @Monokaix @volcano-sh-bot @hwdef