add rescheduling plugin #2098
add rescheduling plugin #2098
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
size/XL
| @@ -503,6 +507,30 @@ func (ssn *Session) ReservedNodes() { | |||
| } | |||
| } | |||
|
|
|||
| // Victims returns the victims for rescheduling | |||
| func (ssn *Session) Victims(tasks []*api.TaskInfo) map[*api.TaskInfo]bool { | |||
There was a problem hiding this comment.
This function should be part of action instead of this plugin.
There was a problem hiding this comment.
Victims get registered functions from ssn.reschedulingFns and then execute them. I think it is better add it in this PR.
There was a problem hiding this comment.
One PR for framework (shuffle action), one pr for implementation (rescheduling plugin).
Victims should be also used by TDM plugin.
There was a problem hiding this comment.
One PR for framework (shuffle action), one pr for implementation (rescheduling plugin).
Victimsshould be also used by TDM plugin.
I get you. It's OK for me. Let me make a update.
Thor-wl
requested review from
william-wang and
shinytang6
and removed request for
merryzhou and
zen-xu
Thor-wl
force-pushed
the
0316-reschedulingPlugin
branch
from
2e8c210
to
639d7dd
Compare
Signed-off-by: Thor-wl <[email protected]>
Thor-wl
force-pushed
the
0316-reschedulingPlugin
branch
from
639d7dd
to
cf6cacc
Compare
ref: #1777
design doc: https://github.com/volcano-sh/volcano/blob/master/docs/design/rescheduling.md
This PR should work together with #2094 #2095 #2096. So please DO NOT merge it until the above PR are merged.
Signed-off-by: Thor-wl [email protected]