Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support executing registered functions registered in plugins regularly #2095

Closed
wants to merge 1 commit into from

Conversation

Thor-wl
Copy link
Contributor

@Thor-wl Thor-wl commented Mar 16, 2022

This function will judge whether the functions registered in plugins should be executed currently, which is useful in scenarios such as rescheduling. This feature has already been used in rescheduling plugin.
Ref: https://github.com/volcano-sh/volcano/pull/2098/files
Signed-off-by: Thor-wl [email protected]

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign thor-wl
You can assign the PR to them by writing /assign @thor-wl in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 16, 2022
This was referenced Mar 16, 2022
@Thor-wl Thor-wl changed the title add IsToBeExecuted function to support executing registered functions… Support executing registered functions registered in plugins regularly Mar 16, 2022
@Thor-wl Thor-wl requested review from shinytang6 and william-wang and removed request for k82cn and alcorj-mizar March 16, 2022 08:41
func init() {
Reservation = NewResourceReservation()
FnsLastExecTime = make(map[string]time.Time)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How to register an exectTimeFn?

@Thor-wl Thor-wl closed this Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants