Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tool functions BuildBestEffortPod and BuildPodWithPriority #2094

Closed
wants to merge 1 commit into from

Conversation

Thor-wl
Copy link
Contributor

@Thor-wl Thor-wl commented Mar 16, 2022

The tool functions will be used in the UT of shuffle action.
Ref: https://github.com/volcano-sh/volcano/pull/2099/files
Signed-off-by: Thor-wl [email protected]

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign thor-wl
You can assign the PR to them by writing /assign @thor-wl in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 16, 2022
This was referenced Mar 16, 2022
@Thor-wl Thor-wl requested review from shinytang6, william-wang, hudson741 and k82cn and removed request for hudson741, k82cn and shinytang6 March 16, 2022 08:40
Copy link
Member

@shinytang6 shinytang6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not include this pr in #2099?

@Thor-wl
Copy link
Contributor Author

Thor-wl commented Mar 21, 2022

why not include this pr in #2099?

I also suggest like that. @k82cn advised to separate the whole PR into different small functions in order to have a good glimpse of the code for reviewer. I think that is also reasonable. These PRs should be merged befrore shuffle action so that that PR can pass the CI.

@k82cn
Copy link
Member

k82cn commented Mar 22, 2022

I also suggest like that. @k82cn advised to separate the whole PR into different small functions in order to have a good glimpse of the code for reviewer.

My suggstion is to create two PRs, one for action, the other for plugins; and those two PRs should not have dependency with each other :)

@Thor-wl Thor-wl closed this Apr 16, 2022
@Thor-wl Thor-wl closed this Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants