fix: add support for vsan file services #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burnsjared0415
force-pushed
the
Bug-Added-support-for-vSAN-File-
branch
from
2a76eca to
51621e3
Compare
burnsjared0415
changed the title
tenthirtyam
changed the title
tenthirtyam
force-pushed
the
Bug-Added-support-for-vSAN-File-
branch
from
51621e3 to
4fc1436
Compare
tenthirtyam
reviewed
Feb 15, 2024
Comment on lines
191
to
192
| $vcfVersion = Get-VCFManager | Select-Object version | Select-String -Pattern '\d+\.\d+' -AllMatches | ForEach-Object { $_.matches.groups[0].value } | ||
|
|
There was a problem hiding this comment.
Suggested change
| $vcfVersion = Get-VCFManager | Select-Object version | Select-String -Pattern '\d+\.\d+' -AllMatches | ForEach-Object { $_.matches.groups[0].value } | |
| $vcfVersion = Get-VCFManager | Select-Object version | Select-String -Pattern '\d+\.\d+' -AllMatches | ForEach-Object { $_.matches.groups[0].value } |
tenthirtyam
reviewed
Feb 15, 2024
Comment on lines
594
to
595
| if ( $answer -eq 'N') { | ||
| Write-PowerManagementLogMessage -Type WARNING "Please shutdown the workload domain vCenter Server instance $vm and retry." |
There was a problem hiding this comment.
Suggested change
| if ( $answer -eq 'N') { | |
| Write-PowerManagementLogMessage -Type WARNING "Please shutdown the workload domain vCenter Server instance $vm and retry." | |
| if ($answer -Match 'N') { | |
| Write-PowerManagementLogMessage -Type ERROR "Please shutdown the workload domain vCenter Server instance $vm and retry. Exiting..." |
tenthirtyam
reviewed
Feb 15, 2024
| @@ -612,6 +614,12 @@ if ($PsBoundParameters.ContainsKey("shutdown") -or $PsBoundParameters.ContainsKe | |||
| foreach ($vm in $vclsvms) { | |||
| [Array]$vcfvms += $vm | |||
| } | |||
| Write-PowerManagementLogMessage -Type INFO -Message "Trying to fetch all powered-on vSAN File Services virtual machines from server $($vcenter)..." | |||
There was a problem hiding this comment.
Suggested change
| Write-PowerManagementLogMessage -Type INFO -Message "Trying to fetch all powered-on vSAN File Services virtual machines from server $($vcenter)..." | |
| Write-PowerManagementLogMessage -Type INFO -Message "Fetching all powered on vSAN File Services virtual machines from vCenter Server instance $($vcenter)..." |
…mentDomain.ps1 Replaced code in `PowerManagement-ManagmentDomain.ps1` updated `$vcfvms` to allow for ip address or FQDN. Signed-off-by: Jared Burns <[email protected]>
Updated `PowerManagement-ManagmentDomain.ps1` to allow for FQDN or IP address of SDDC Manager. Signed-off-by: Jared Burns <[email protected]>
Added support to `PowerManagement-ManagmentDomain.ps1` for more than one cluster in management domain for shut down and start up. Signed-off-by: Jared Burns <[email protected]>
Added support to PowerManagement-ManagmentDomain.ps1 for more than one cluster in management domain for shut down and start up. Signed-off-by: Jared Burns <[email protected]>
Added support to `PowerManagement-ManagmentDomain.ps1` and `PowerManagement-WorkloadDomain.ps1` for vSAN File Services to be excluded from customer virtual machines. Signed-off-by: Jared Burns <[email protected]>
tenthirtyam
force-pushed
the
Bug-Added-support-for-vSAN-File-
branch
from
4fc1436 to
50b95fa
Compare
11 tasks
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added support to
PowerManagement-ManagmentDomain.ps1andPowerManagement-WorkloadDomain.ps1for vSAN File Services to be excluded from customer virtual machines.Type
Please describe:
Breaking Changes?
Test and Documentation
Issue References
Closes #48
Additional Information