Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for multiple clusters in mgmt domain #93

Merged
merged 1 commit into from
Feb 15, 2024
Merged

feat: add support for multiple clusters in mgmt domain #93

merged 1 commit into from
Feb 15, 2024

Conversation

burnsjared0415
Copy link
Contributor

@burnsjared0415 burnsjared0415 commented Feb 14, 2024 •
edited by tenthirtyam
Loading

Summary

Added support to PowerManagement-ManagmentDomain.ps1 for more than one cluster in management domain for shut down and start up.

Type

  • Bugfix
  • Enhancement or Feature
  • Code Style or Formatting
  • Documentation
  • Refactoring
  • Chore
  • Other
    Please describe:

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.
  • Documentation has been added or updated.

Issue References

Closes #41

Additional Information

@github-actions github-actions bot added documentation Documentation needs-review Needs Review labels Feb 14, 2024
@burnsjared0415 burnsjared0415 force-pushed the feat-added-Check-again-Mgmt-cluster branch 2 times, most recently from f7042aa to 8adf431 Compare February 14, 2024 23:04
@tenthirtyam tenthirtyam self-requested a review February 15, 2024 14:16
@tenthirtyam tenthirtyam added this to the v1.4.1 milestone Feb 15, 2024
@tenthirtyam tenthirtyam force-pushed the feat-added-Check-again-Mgmt-cluster branch from 8adf431 to b4a2ca1 Compare February 15, 2024 14:24
@tenthirtyam tenthirtyam changed the title Feat: added check again mgmt cluster feat: added support for multiple clusters in mgmt domain Feb 15, 2024
@tenthirtyam tenthirtyam marked this pull request as ready for review February 15, 2024 14:24
@tenthirtyam tenthirtyam requested a review from a team as a code owner February 15, 2024 14:24
@github-actions github-actions bot added the needs-review Needs Review label Feb 15, 2024
@tenthirtyam tenthirtyam changed the title feat: added support for multiple clusters in mgmt domain feat: add support for multiple clusters in mgmt domain Feb 15, 2024
@tenthirtyam tenthirtyam force-pushed the feat-added-Check-again-Mgmt-cluster branch from aa81ff1 to 4713fa8 Compare February 15, 2024 18:27
@vmwclabot vmwclabot removed the dco-required DCO Required label Feb 15, 2024
@burnsjared0415 burnsjared0415 force-pushed the feat-added-Check-again-Mgmt-cluster branch 2 times, most recently from bd198bc to 82cc0e0 Compare February 15, 2024 19:05
@burnsjared0415
feat: add support for multiple clusters in mgmt domain
e96853e 
Added support to `PowerManagement-ManagmentDomain.ps1` for more than one cluster in management domain for shut down and start up.

Signed-off-by: Jared Burns <[email protected]>

feat: Added support for multiple clusters in mgmt domain

Added support to `PowerManagement-ManagmentDomain.ps1` for more than one cluster in management domain for shut down and start up.

Signed-off-by: Jared Burns <[email protected]>

refactor: added code to allow for IP address on PowerManagement-ManagmentDomain.ps1

Replaced code in `PowerManagement-ManagmentDomain.ps1` updated `$vcfvms` to allow for ip address or FQDN.

Signed-off-by: Jared Burns <[email protected]>

feat: added support for multiple clusters in mgmt domain

Added support for more than one cluster in management domain for shut down and start up to `PowerManagement-ManagmentDomain.ps1`.

Signed-off-by: Jared Burns <[email protected]>
@burnsjared0415 burnsjared0415 force-pushed the feat-added-Check-again-Mgmt-cluster branch from 82cc0e0 to e96853e Compare February 15, 2024 19:07
tenthirtyam
tenthirtyam approved these changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for knocking this one out! :)

@tenthirtyam tenthirtyam removed the needs-review Needs Review label Feb 15, 2024
@tenthirtyam tenthirtyam merged commit 7bb91ba into vmware:develop Feb 15, 2024
1 check passed
tenthirtyam pushed a commit to burnsjared0415/powershell-module-for-vmware-cloud-foundation-power-management that referenced this pull request Feb 15, 2024
@burnsjared0415 @tenthirtyam
feat: add support for multiple clusters in mgmt domain (vmware#93)
71e5e28 
Added support to PowerManagement-ManagmentDomain.ps1 for more than one cluster in management domain for shut down and start up.

Signed-off-by: Jared Burns <[email protected]>
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
@tenthirtyam tenthirtyam modified the milestones: v1.4.1, v1.4.2 Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tenthirtyam tenthirtyam tenthirtyam approved these changes

Assignees

@burnsjared0415 burnsjared0415

Labels
documentation Documentation
Projects
None yet
Milestone
v1.4.1
Development

Successfully merging this pull request may close these issues.

Add support for multiple clusters in a management domain
3 participants
@burnsjared0415 @vmwclabot @tenthirtyam