Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for vsan file services #95

Merged

Conversation

burnsjared0415
Copy link
Contributor

@burnsjared0415 burnsjared0415 commented Feb 15, 2024

Summary

Added support to PowerManagement-ManagmentDomain.ps1 and PowerManagement-WorkloadDomain.ps1 for vSAN File Services to be excluded from customer virtual machines.

Type

  • Bugfix
  • Enhancement or Feature
  • Code Style or Formatting
  • Documentation
  • Refactoring
  • Chore
  • Other
    Please describe:

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.
  • Documentation has been added or updated.

Issue References

Closes #48

Additional Information

@github-actions github-actions bot added documentation Documentation needs-review Needs Review labels Feb 15, 2024
Added support to `PowerManagement-ManagmentDomain.ps1` and `PowerManagement-WorkloadDomain.ps1` for vSAN File Services to be excluded from customer virtual machines.

Signed-off-by: Jared Burns <[email protected]>
@burnsjared0415 burnsjared0415 force-pushed the fix/add-support-vsan-file-services branch from ddb9023 to 27525bc Compare February 15, 2024 19:48
@tenthirtyam tenthirtyam self-requested a review February 15, 2024 19:49
@tenthirtyam tenthirtyam added this to the v1.4.1 milestone Feb 15, 2024
@tenthirtyam tenthirtyam marked this pull request as ready for review February 15, 2024 19:50
@tenthirtyam tenthirtyam requested a review from a team as a code owner February 15, 2024 19:50
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@tenthirtyam tenthirtyam merged commit f1c77c2 into vmware:develop Feb 15, 2024
3 checks passed
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Feb 15, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
@tenthirtyam tenthirtyam modified the milestones: v1.4.1, v1.4.2 Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When vSAN File Services is enabled the workload domain shutdown attempts to shutdown the service nodes
2 participants