Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix go lint issues highlighted in Go report Card #250

Closed
dharmjit opened this issue Nov 17, 2021 · 10 comments · Fixed by #405 or #422
Closed

Fix go lint issues highlighted in Go report Card #250

dharmjit opened this issue Nov 17, 2021 · 10 comments · Fixed by #405 or #422
Assignees
Milestone

Comments

@dharmjit
Copy link
Contributor

Go Report Card Results for go lint is only 56%. Most of these are for exported fields/methods not having comments. We need to fix these lint issues.

@raunaksingwi
Copy link
Contributor

I can take this one

@anusha94
Copy link
Contributor

/assign raunaksingwi

@jayesh-srivastava
Copy link

Hi. Was wondering if @raunaksingwi is still working on this issue. If not then I would like to work on this.

@anusha94
Copy link
Contributor

/unassign @raunaksingwi
/assign @jayesh-srivastava

Thanks for picking it up @jayesh-srivastava !

@anusha94
Copy link
Contributor

anusha94 commented Feb 3, 2022

Hey @jayesh-srivastava !
Let us know if you need any assistance.

@jayesh-srivastava
Copy link

jayesh-srivastava commented Feb 12, 2022

Hi @anusha94 I was working on the issue. There are a lot of files that need modifications. I was thinking of making multiple PRs for different packages as it would be then easier to review. Any thoughts?
Or maybe several commits for the same PR would help too.

@anusha94
Copy link
Contributor

@jayesh-srivastava
That sounds good!

@jayesh-srivastava
Copy link

jayesh-srivastava commented Feb 12, 2022

Also @anusha94 a lot of issues regarding this are related to structs and functions not having comments. I'll have to manually do this because there is no autofix for golint. How should I do this because to know what each structs and functions do, that is a nearly impossible task I guess.

exported type ScriptExecutor should have comment or be unexported
comment on exported type IFileWriter should be of the form "IFileWriter ..." (with optional leading article)

These are some examples of the issues coming up. Am I able to understand it the right way?

@anusha94
Copy link
Contributor

anusha94 commented Feb 12, 2022

@jayesh-srivastava that's a fair call-out. I haven't taken a look at the lint errors myself. But from the issue description, it's indeed mostly comments.
I can create a task list for this issue for different categories of lint errors. Probably then it will be easier for you to work on a subset of these tasks?
One of us on the byoh team can work on the missing comments.

@jayesh-srivastava
Copy link

@anusha94 That would work. I guess 99 percent of the issues are only comments. The ones which are not, I'll work and make the PR for it. The ones with the comment, maybe I can assist anyone on the byoh team who'll be working on this as the number of issues are a lot.

@anusha94 anusha94 removed this from the v0.1.1 milestone Feb 17, 2022
pshail added a commit to pshail/cluster-api-provider-bringyourownhost that referenced this issue Feb 28, 2022
 fixes vmware-tanzu#250

Signed-off-by: Shailesh Pant <[email protected]>
pshail added a commit to pshail/cluster-api-provider-bringyourownhost that referenced this issue Mar 1, 2022
 fixes vmware-tanzu#250

Signed-off-by: Shailesh Pant <[email protected]>
pshail added a commit to pshail/cluster-api-provider-bringyourownhost that referenced this issue Mar 1, 2022
 fixes vmware-tanzu#250

Signed-off-by: Shailesh Pant <[email protected]>
pshail added a commit to pshail/cluster-api-provider-bringyourownhost that referenced this issue Mar 1, 2022
 fixes vmware-tanzu#250

Signed-off-by: Shailesh Pant <[email protected]>
pshail added a commit to pshail/cluster-api-provider-bringyourownhost that referenced this issue Mar 1, 2022
 fixes vmware-tanzu#250

Signed-off-by: Shailesh Pant <[email protected]>
@anusha94 anusha94 added this to the Next milestone Mar 4, 2022
pshail added a commit to pshail/cluster-api-provider-bringyourownhost that referenced this issue Mar 10, 2022
 - Minor code improvements
fixes vmware-tanzu#250

Signed-off-by: Shailesh Pant <[email protected]>
pshail added a commit to pshail/cluster-api-provider-bringyourownhost that referenced this issue Mar 10, 2022
 - Minor code improvements
fixes vmware-tanzu#250

Signed-off-by: Shailesh Pant <[email protected]>
pshail added a commit to pshail/cluster-api-provider-bringyourownhost that referenced this issue Mar 10, 2022
 - Minor code improvements
 - Unexported locally used variables
fixes vmware-tanzu#250

Signed-off-by: Shailesh Pant <[email protected]>
pshail added a commit to pshail/cluster-api-provider-bringyourownhost that referenced this issue Mar 16, 2022
 - Minor code improvements
 - Unexported locally used variables
fixes vmware-tanzu#250

Signed-off-by: Shailesh Pant <[email protected]>
pshail added a commit to pshail/cluster-api-provider-bringyourownhost that referenced this issue Mar 21, 2022
 - Minor code improvements
 - Unexported locally used variables
fixes vmware-tanzu#250

-- Rebased --
 21st March

Signed-off-by: Shailesh Pant <[email protected]>
pshail added a commit to pshail/cluster-api-provider-bringyourownhost that referenced this issue Mar 21, 2022
 - Minor code improvements
 - Unexported locally used variables
fixes vmware-tanzu#250

-- Rebased --
 21st March

Signed-off-by: Shailesh Pant <[email protected]>
pshail added a commit to pshail/cluster-api-provider-bringyourownhost that referenced this issue Mar 21, 2022
 - Minor code improvements
 - Unexported locally used variables
fixes vmware-tanzu#250

-- Rebased --
 21st March

Signed-off-by: Shailesh Pant <[email protected]>
pshail added a commit to pshail/cluster-api-provider-bringyourownhost that referenced this issue Mar 21, 2022
 - Minor code improvements
 - Unexported locally used variables
fixes vmware-tanzu#250

-- Rebased --
 21st March

Signed-off-by: Shailesh Pant <[email protected]>
pshail added a commit to pshail/cluster-api-provider-bringyourownhost that referenced this issue Mar 21, 2022
 - Minor code improvements
 - Unexported locally used variables
fixes vmware-tanzu#250

-- Rebased --
 21st March

Signed-off-by: Shailesh Pant <[email protected]>
pshail added a commit to pshail/cluster-api-provider-bringyourownhost that referenced this issue Mar 21, 2022
 - Minor code improvements
 - Unexported locally used variables
fixes vmware-tanzu#250

-- Rebased --
 21st March

Signed-off-by: Shailesh Pant <[email protected]>
pshail added a commit to pshail/cluster-api-provider-bringyourownhost that referenced this issue Mar 21, 2022
 - Minor code improvements
 - Unexported locally used variables
fixes vmware-tanzu#250

-- Rebased --
 21st March

Signed-off-by: Shailesh Pant <[email protected]>
anusha94 pushed a commit that referenced this issue Mar 22, 2022
- Minor code improvements
 - Unexported locally used variables
fixes #250

-- Rebased --
 21st March

Signed-off-by: Shailesh Pant <[email protected]>
@anusha94 anusha94 modified the milestones: Next, v0.2.0 Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment