-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix go lint issues highlighted in Go report Card #250
Comments
I can take this one |
/assign raunaksingwi |
Hi. Was wondering if @raunaksingwi is still working on this issue. If not then I would like to work on this. |
/unassign @raunaksingwi Thanks for picking it up @jayesh-srivastava ! |
Hey @jayesh-srivastava ! |
Hi @anusha94 I was working on the issue. There are a lot of files that need modifications. I was thinking of making multiple PRs for different packages as it would be then easier to review. Any thoughts? |
@jayesh-srivastava |
Also @anusha94 a lot of issues regarding this are related to structs and functions not having comments. I'll have to manually do this because there is no autofix for golint. How should I do this because to know what each structs and functions do, that is a nearly impossible task I guess.
These are some examples of the issues coming up. Am I able to understand it the right way? |
@jayesh-srivastava that's a fair call-out. I haven't taken a look at the lint errors myself. But from the issue description, it's indeed mostly comments. |
@anusha94 That would work. I guess 99 percent of the issues are only comments. The ones which are not, I'll work and make the PR for it. The ones with the comment, maybe I can assist anyone on the byoh team who'll be working on this as the number of issues are a lot. |
fixes vmware-tanzu#250 Signed-off-by: Shailesh Pant <[email protected]>
fixes vmware-tanzu#250 Signed-off-by: Shailesh Pant <[email protected]>
fixes vmware-tanzu#250 Signed-off-by: Shailesh Pant <[email protected]>
fixes vmware-tanzu#250 Signed-off-by: Shailesh Pant <[email protected]>
fixes vmware-tanzu#250 Signed-off-by: Shailesh Pant <[email protected]>
- Minor code improvements fixes vmware-tanzu#250 Signed-off-by: Shailesh Pant <[email protected]>
- Minor code improvements fixes vmware-tanzu#250 Signed-off-by: Shailesh Pant <[email protected]>
- Minor code improvements - Unexported locally used variables fixes vmware-tanzu#250 Signed-off-by: Shailesh Pant <[email protected]>
- Minor code improvements - Unexported locally used variables fixes vmware-tanzu#250 Signed-off-by: Shailesh Pant <[email protected]>
- Minor code improvements - Unexported locally used variables fixes vmware-tanzu#250 -- Rebased -- 21st March Signed-off-by: Shailesh Pant <[email protected]>
- Minor code improvements - Unexported locally used variables fixes vmware-tanzu#250 -- Rebased -- 21st March Signed-off-by: Shailesh Pant <[email protected]>
- Minor code improvements - Unexported locally used variables fixes vmware-tanzu#250 -- Rebased -- 21st March Signed-off-by: Shailesh Pant <[email protected]>
- Minor code improvements - Unexported locally used variables fixes vmware-tanzu#250 -- Rebased -- 21st March Signed-off-by: Shailesh Pant <[email protected]>
- Minor code improvements - Unexported locally used variables fixes vmware-tanzu#250 -- Rebased -- 21st March Signed-off-by: Shailesh Pant <[email protected]>
- Minor code improvements - Unexported locally used variables fixes vmware-tanzu#250 -- Rebased -- 21st March Signed-off-by: Shailesh Pant <[email protected]>
- Minor code improvements - Unexported locally used variables fixes vmware-tanzu#250 -- Rebased -- 21st March Signed-off-by: Shailesh Pant <[email protected]>
- Minor code improvements - Unexported locally used variables fixes #250 -- Rebased -- 21st March Signed-off-by: Shailesh Pant <[email protected]>
Go Report Card Results for go lint is only 56%. Most of these are for exported fields/methods not having comments. We need to fix these lint issues.
The text was updated successfully, but these errors were encountered: