Fix some golint issues and add its dependencies #379
Conversation
|
@jayesh-srivastava, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction. |
|
cc @anusha94 |
| @@ -17,8 +17,7 @@ import ( | |||
| "github.com/docker/docker/api/types/network" | |||
| "github.com/docker/docker/client" | |||
| "github.com/docker/docker/pkg/archive" | |||
| "github.com/docker/docker/pkg/system" | |||
| . "github.com/onsi/gomega" // nolint: stylecheck | |||
There was a problem hiding this comment.
Removing gomega is causing all sorts of lint and test errors I believe.
There was a problem hiding this comment.
The no lint comment was used for gomega but that's an unused import and vscode itself removes it while saving the file.
|
@anusha94 I guess the issues are related to linters. Also the golangci-lint linters aren't in parity with CAPI which should be the case because it helps in making the developer experience same. I've seen these issues for other CAP* projects like CAPZ and CAPG. I'll open the same for CAP-BYOH as well. After closing that issue, I guess this should work. |
|
@jayesh-srivastava, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement. |
|
@jayesh-srivastava, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement. |
What this PR does / why we need it:
This PR fixes some non-comment related golint issues and also adds its dependencies.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):This PR partially fixes #250
Special notes for your reviewer
This PR only fixes some of the golint issues. A majority of the issues were related to structs and functions not being commented which is why I'm unable to work on those as I don't have a clear understanding of the whole codebase atm.
P.S - cluster-api-provider-bringyourownhost/issues/250#issuecomment-1037227086 and following comments.