Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes for linting changes after running make test #422

Merged
merged 2 commits into from
Mar 16, 2022

Conversation

sachinkumarsingh092
Copy link
Contributor

What this PR does / why we need it:
Some files are modified after using make test by the linter. We don't want that to happen everytime we run make test.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Partially Fixes #250

Additional information

Special notes for your reviewer

@sachinkumarsingh092
Copy link
Contributor Author

/cc @dharmjit @anusha94

NilanjanDaw
NilanjanDaw previously approved these changes Mar 7, 2022
Copy link
Contributor

@NilanjanDaw NilanjanDaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

dharmjit
dharmjit previously approved these changes Mar 15, 2022
Copy link
Contributor

@dharmjit dharmjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@anusha94 anusha94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dharmjit dharmjit merged commit 3e0b04f into vmware-tanzu:main Mar 16, 2022
@sachinkumarsingh092 sachinkumarsingh092 deleted the fix-make-test-lints branch March 16, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix go lint issues highlighted in Go report Card
5 participants