cargo_build_script: Add support for -fsanitize-ignorelist=
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
vitalybuka
commented
Oct 14, 2024
•
vitalybuka
commented
Revert "Restore lost "is_absolute" (bazelbuild#2922)" This reverts commit 2a85e13. Revert "Use absolute path with "-fsanitize-ignorelist" (bazelbuild#2911)" This reverts commit 9594fa7.
…2927) This allows target specific flags to override toolchain specific flags, e.g: to disable LTO on examples.
…bazelbuild#2931) Follow-up from bazelbuild#2917: add some cargo_build_script regression tests for the cc_toolchain processing.
This is trivial copy/paste implementation, to minimize regression probability. Previously it was combined with refactoring, but introduced regression and was reverted bazelbuild#2911. This time I split refactoring into follow up PR.
vitalybuka
changed the title
-fsanitize-ignorelist=
vitalybuka
changed the title
-fsanitize-ignorelist=-fsanitize-ignorelist=
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.