Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore lost "is_absolute" #2922

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Restore lost "is_absolute" #2922

merged 1 commit into from
Oct 7, 2024

Conversation

vitalybuka
Copy link
Contributor

is_absolute was lost for "=" case in #2911

Fixes #2917

@vitalybuka
Restore lost "is_absolute"
f391a92 
`is_absolute` was lost for "=" case in bazelbuild#2911

Fixes  bazelbuild#2917
This was referenced Oct 6, 2024
Closed
Closed
UebelAndre
UebelAndre requested changes Oct 6, 2024
View reviewed changes
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Don’t mean to burden you after dealing with the regression but Is this something that can be regression tested?

@vitalybuka
Copy link
Contributor Author

I am not sure how to do that in reasonable way. Looks like there is no a single test which fail if I "return []" from _pwd_flags.

I am very new to this code, could you please suggest which test could be the likely example for requested test?

@UebelAndre UebelAndre added this pull request to the merge queue Oct 6, 2024
Merged via the queue into bazelbuild:main with commit 2a85e13 Oct 7, 2024
4 checks passed
vitalybuka added a commit to vitalybuka/rules_rust that referenced this pull request Oct 7, 2024
@vitalybuka
Fix fix_next_arg condition
aae6c1e 
Follow up to bazelbuild#2922.

Before bazelbuild#2922 the only possible "else" with "opt"
was space separated flags. Now we get there for
already `is_absolute` path.
@vitalybuka vitalybuka mentioned this pull request Oct 7, 2024
Open
UebelAndre added a commit to UebelAndre/rules_rust that referenced this pull request Oct 7, 2024
@UebelAndre
Revert "Restore lost "is_absolute" (bazelbuild#2922)"
7a322f4 
This reverts commit 2a85e13.
@UebelAndre UebelAndre mentioned this pull request Oct 7, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 7, 2024
@UebelAndre
Revert #2911 and #2922 (#2925)
7890b42 
Revert "Restore lost "is_absolute" (#2922)"

This reverts commit 2a85e13.

Revert "Use absolute path with "-fsanitize-ignorelist" (#2911)"

This reverts commit 9594fa7.
zemnmez-renovate-bot added a commit to zemn-me/monorepo that referenced this pull request Oct 7, 2024
@zemnmez-renovate-bot
chore(deps): update dependency rules_rust to v0.52.2
2747bd5 
##### [`v0.52.2](https://github.com/bazelbuild/rules_rust/releases/tag/0.52.2)

### 0.52.2

#### Bzlmod

```python
bazel_dep(name = "rules_rust", version = "0.52.2")
```

#### WORKSPACE

```python
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
http_archive(
    name = "rules_rust",
    integrity = "sha256-Zx3bP+Xrz53TTQUeynNS+68z+lO/Ye7Qt1pMNIKeVIA=",
    urls = ["https://github.com/bazelbuild/rules_rust/releases/download/0.52.2/rules_rust-v0.52.2.tar.gz"],
)
```

Additional documentation can be found at: https://bazelbuild.github.io/rules_rust/#setup

#### What's Changed

-   Restore lost "is_absolute" by [@vitalybuka](https://github.com/vitalybuka) in bazelbuild/rules_rust#2922
-   Revert [#2911](bazelbuild/rules_rust#2911) and [#2922](bazelbuild/rules_rust#2922) by [@UebelAndre](https://github.com/UebelAndre) in bazelbuild/rules_rust#2925

**Full Changelog**: bazelbuild/rules_rust@0.52.1...0.52.2
github-merge-queue bot pushed a commit to zemn-me/monorepo that referenced this pull request Oct 8, 2024
@zemnmez-renovate-bot
chore(deps): update dependency rules_rust to v0.52.2
d7ee85e 
##### [`v0.52.2](https://github.com/bazelbuild/rules_rust/releases/tag/0.52.2)

### 0.52.2

#### Bzlmod

```python
bazel_dep(name = "rules_rust", version = "0.52.2")
```

#### WORKSPACE

```python
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
http_archive(
    name = "rules_rust",
    integrity = "sha256-Zx3bP+Xrz53TTQUeynNS+68z+lO/Ye7Qt1pMNIKeVIA=",
    urls = ["https://github.com/bazelbuild/rules_rust/releases/download/0.52.2/rules_rust-v0.52.2.tar.gz"],
)
```

Additional documentation can be found at: https://bazelbuild.github.io/rules_rust/#setup

#### What's Changed

-   Restore lost "is_absolute" by [@vitalybuka](https://github.com/vitalybuka) in bazelbuild/rules_rust#2922
-   Revert [#2911](bazelbuild/rules_rust#2911) and [#2922](bazelbuild/rules_rust#2922) by [@UebelAndre](https://github.com/UebelAndre) in bazelbuild/rules_rust#2925

**Full Changelog**: bazelbuild/rules_rust@0.52.1...0.52.2
@vitalybuka vitalybuka mentioned this pull request Oct 14, 2024
Closed
vitalybuka added a commit to vitalybuka/rules_rust that referenced this pull request Oct 14, 2024
@vitalybuka
cargo_build_script: Add regression for revert bazelbuild#2925
f4808a6 
Existing test passes with bazelbuild#2911 and bazelbuild#2922.
However even bazelbuild#2922 was breaking something.
I suspect case like this is the cause.
@vitalybuka vitalybuka mentioned this pull request Oct 14, 2024
Merged
vitalybuka added a commit to vitalybuka/rules_rust that referenced this pull request Oct 15, 2024
@vitalybuka
cargo_build_script: Add regression for revert bazelbuild#2925
55eda38 
Existing test passes with bazelbuild#2911 and bazelbuild#2922.
However even bazelbuild#2922 was breaking something.
I suspect case like this is the cause.
vitalybuka added a commit to vitalybuka/rules_rust that referenced this pull request Oct 16, 2024
@vitalybuka
Revert "Revert bazelbuild#2911 and bazelbuild#2922 (bazelbuild#2925)"
294a549 
This reverts commit 7890b42.
vitalybuka added a commit to vitalybuka/rules_rust that referenced this pull request Oct 16, 2024
@vitalybuka
cargo_build_script: Add regression for revert bazelbuild#2925
1b3273b 
Existing test passes with bazelbuild#2911 and bazelbuild#2922.
However even bazelbuild#2922 was breaking something.
I suspect case like this is the cause.
vitalybuka added a commit to vitalybuka/rules_rust that referenced this pull request Oct 17, 2024
@vitalybuka
cargo_build_script: Add regression for revert bazelbuild#2925
f3d4acb 
Existing test passes with bazelbuild#2911 and bazelbuild#2922.
However even bazelbuild#2922 was breaking something.
I suspect case like this is the cause.
github-merge-queue bot pushed a commit that referenced this pull request Oct 17, 2024
@vitalybuka
cargo_build_script: Add regression test for revert #2925 (#2936)
0c6bcc8 
#2931 added tests for _pwd_flags, however 
the test as-is passes with #2911 and #2922,
which still caused problems and reverted.
Here I introduce a test case for likely
unfixed in reverted #2925.

The test needs strictter check for cflags. As-ls
`flag in cflags` is a just substring search and
very weak test for abs path.

For #2917
vitalybuka added a commit to vitalybuka/rules_rust that referenced this pull request Oct 21, 2024
@vitalybuka
Revert "Revert bazelbuild#2911 and bazelbuild#2922 (bazelbuild#2925)"
d9a9f95 
This reverts commit 7890b42.
vitalybuka added a commit to vitalybuka/rules_rust that referenced this pull request Oct 21, 2024
@vitalybuka
cargo_build_script: De-duplicate _pwd_flags implementation
da673eb 
This reverts bazelbuild#2925 to reland bazelbuild#2911 and bazelbuild#2922,
with required fix, the second patch in the PR.
@vitalybuka vitalybuka mentioned this pull request Oct 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UebelAndre UebelAndre UebelAndre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

0.52.0 breaks cross compilation of sys dependencies
2 participants
@vitalybuka @UebelAndre