Revert #2911 and #2922 #2925
Merged
Revert #2911 and #2922 #2925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change will also kick off a |
vitalybuka
approved these changes
Oct 7, 2024
illicitonion
approved these changes
Oct 7, 2024
zemnmez-renovate-bot
added a commit
to zemn-me/monorepo
that referenced
this pull request
Oct 7, 2024
##### [`v0.52.2](https://github.com/bazelbuild/rules_rust/releases/tag/0.52.2) ### 0.52.2 #### Bzlmod ```python bazel_dep(name = "rules_rust", version = "0.52.2") ``` #### WORKSPACE ```python load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "rules_rust", integrity = "sha256-Zx3bP+Xrz53TTQUeynNS+68z+lO/Ye7Qt1pMNIKeVIA=", urls = ["https://github.com/bazelbuild/rules_rust/releases/download/0.52.2/rules_rust-v0.52.2.tar.gz"], ) ``` Additional documentation can be found at: https://bazelbuild.github.io/rules_rust/#setup #### What's Changed - Restore lost "is_absolute" by [@vitalybuka](https://github.com/vitalybuka) in bazelbuild/rules_rust#2922 - Revert [#2911](bazelbuild/rules_rust#2911) and [#2922](bazelbuild/rules_rust#2922) by [@UebelAndre](https://github.com/UebelAndre) in bazelbuild/rules_rust#2925 **Full Changelog**: bazelbuild/rules_rust@0.52.1...0.52.2
github-merge-queue bot
pushed a commit
to zemn-me/monorepo
that referenced
this pull request
Oct 8, 2024
##### [`v0.52.2](https://github.com/bazelbuild/rules_rust/releases/tag/0.52.2) ### 0.52.2 #### Bzlmod ```python bazel_dep(name = "rules_rust", version = "0.52.2") ``` #### WORKSPACE ```python load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "rules_rust", integrity = "sha256-Zx3bP+Xrz53TTQUeynNS+68z+lO/Ye7Qt1pMNIKeVIA=", urls = ["https://github.com/bazelbuild/rules_rust/releases/download/0.52.2/rules_rust-v0.52.2.tar.gz"], ) ``` Additional documentation can be found at: https://bazelbuild.github.io/rules_rust/#setup #### What's Changed - Restore lost "is_absolute" by [@vitalybuka](https://github.com/vitalybuka) in bazelbuild/rules_rust#2922 - Revert [#2911](bazelbuild/rules_rust#2911) and [#2922](bazelbuild/rules_rust#2922) by [@UebelAndre](https://github.com/UebelAndre) in bazelbuild/rules_rust#2925 **Full Changelog**: bazelbuild/rules_rust@0.52.1...0.52.2
vitalybuka
added a commit
to vitalybuka/rules_rust
that referenced
this pull request
Oct 14, 2024
Existing test passes with bazelbuild#2911 and bazelbuild#2922. However even bazelbuild#2922 was breaking something. I suspect case like this is the cause.
vitalybuka
added a commit
to vitalybuka/rules_rust
that referenced
this pull request
Oct 15, 2024
Existing test passes with bazelbuild#2911 and bazelbuild#2922. However even bazelbuild#2922 was breaking something. I suspect case like this is the cause.
vitalybuka
added a commit
to vitalybuka/rules_rust
that referenced
this pull request
Oct 16, 2024
This reverts commit 7890b42.
vitalybuka
added a commit
to vitalybuka/rules_rust
that referenced
this pull request
Oct 16, 2024
Existing test passes with bazelbuild#2911 and bazelbuild#2922. However even bazelbuild#2922 was breaking something. I suspect case like this is the cause.
vitalybuka
added a commit
to vitalybuka/rules_rust
that referenced
this pull request
Oct 17, 2024
Existing test passes with bazelbuild#2911 and bazelbuild#2922. However even bazelbuild#2922 was breaking something. I suspect case like this is the cause.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 17, 2024
#2931 added tests for _pwd_flags, however the test as-is passes with #2911 and #2922, which still caused problems and reverted. Here I introduce a test case for likely unfixed in reverted #2925. The test needs strictter check for cflags. As-ls `flag in cflags` is a just substring search and very weak test for abs path. For #2917
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "Restore lost "is_absolute" (#2922)"
This reverts commit 2a85e13.
Revert "Use absolute path with "-fsanitize-ignorelist" (#2911)"
This reverts commit 9594fa7.