Components are now accessible via camelCase and UpperCamelCase me…
#3439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -361,7 +361,7 @@ class Component { | |||
|
|
|||
| // If no componentClass in options, assume componentClass is the name lowercased | |||
There was a problem hiding this comment.
comment might need to be updated.
There was a problem hiding this comment.
I think this comment could just be removed?
chemoish
force-pushed
the
feature/fix-component-sensitivity
branch
from
de10475 to
ff54edc
Compare
|
Looks like this needs to be rebased against master |
chemoish
force-pushed
the
feature/fix-component-sensitivity
branch
from
ff54edc to
78db9f2
Compare
|
@gkatsev I temporarily removed |
…ans. - addChild - getChild - getComponent - registerComponent
chemoish
force-pushed
the
feature/fix-component-sensitivity
branch
from
78db9f2 to
f94c3d9
Compare
|
@gkatsev updated again. |
gkatsev
approved these changes
Sep 27, 2016
|
@gkatsev, Is that a known issue? I wasn't having that issue with FF 48, but I am having it with 49.0.1, does that have to do with me? (removing the extraneous comment) |
gkatsev
added
confirmed
minor
|
@hartman unfortunately, it doesn't. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3436.
Description
Components are not uniformly accessible through the same names.
Example:
getChildcannot retrieve a component by acamelCasenameaddChildcan retrieve, then add a component by acamelCasenameSpecific Changes proposed
Enable components to be accessed via both
camelCaseandUpperCamelCasemeans.Requirements Checklist
…ans.